From: Karsten Graul <kgraul@linux.ibm.com>
To: Tony Lu <tonylu@linux.alibaba.com>, yacanliu@163.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
liuyacan <liuyacan@corp.netease.com>
Subject: Re: [PATCH] net/smc: sync err info when TCP connection is refused
Date: Tue, 19 Apr 2022 12:37:12 +0200 [thread overview]
Message-ID: <ed643c3d-6ad0-1b3c-1fe3-9157e7aa5859@linux.ibm.com> (raw)
In-Reply-To: <Yl6Nnvnrvqv3ofES@TonyMac-Alibaba>
On 19/04/2022 12:23, Tony Lu wrote:
> On Sun, Apr 17, 2022 at 08:33:07PM +0800, yacanliu@163.com wrote:
>> From: liuyacan <liuyacan@corp.netease.com>
>>
>> In the current implementation, when TCP initiates a connection
>> to an unavailable [ip,port], ECONNREFUSED will be stored in the
>> TCP socket, but SMC will not. However, some apps (like curl) use
>> getsockopt(,,SO_ERROR,,) to get the error information, which makes
>> them miss the error message and behave strangely.
>>
>> Signed-off-by: liuyacan <liuyacan@corp.netease.com>
>
> This fix works for me. I have tested it with curl for unavailable
> address.
>
> This patch missed net or net-next tag, I think net is preferred.
>
> Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
>
> Thank you,
> Tony Lu
Thank you both for the fix and the test!
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
next prev parent reply other threads:[~2022-04-19 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 12:33 [PATCH] net/smc: sync err info when TCP connection is refused yacanliu
2022-04-19 10:23 ` Tony Lu
2022-04-19 10:37 ` Karsten Graul [this message]
2022-04-21 8:09 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed643c3d-6ad0-1b3c-1fe3-9157e7aa5859@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liuyacan@corp.netease.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=yacanliu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).