From mboxrd@z Thu Jan 1 00:00:00 1970 From: tejaswit@codeaurora.org Subject: Re: [PATCH] slip: Check if rstate is initialized before uncompressing Date: Tue, 10 Apr 2018 11:28:10 +0530 Message-ID: References: <20180409085345.GA5972@tejaswit-linux.qualcomm.com> <20180409.110438.458180702294361660.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_db13bcc130a1f3eb01d8d15e1c365439" Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41854 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682AbeDJF6L (ORCPT ); Tue, 10 Apr 2018 01:58:11 -0400 In-Reply-To: <20180409.110438.458180702294361660.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: --=_db13bcc130a1f3eb01d8d15e1c365439 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2018-04-09 20:34, David Miller wrote: > From: Tejaswi Tanikella > Date: Mon, 9 Apr 2018 14:23:49 +0530 > >> @@ -673,6 +677,7 @@ struct slcompress * >> if (cs->cs_tcp.doff > 5) >> memcpy(cs->cs_tcpopt, icp + ihl*4 + sizeof(struct tcphdr), >> (cs->cs_tcp.doff - 5) * 4); >> cs->cs_hsize = ihl*2 + cs->cs_tcp.doff*2; >> + cs->initialized = 1; >> /* Put headers back on packet > ... >> struct cstate { >> byte_t cs_this; /* connection id number (xmit) */ >> + byte_t initialized; /* non-zero if initialized */ > > Please use 'bool' and true/false for 'initialized'. Made the changes. --=_db13bcc130a1f3eb01d8d15e1c365439 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-slip-Check-if-rstate-is-initialized-before-uncompres.patch Content-Disposition: attachment; filename=0001-slip-Check-if-rstate-is-initialized-before-uncompres.patch; size=3032 RnJvbSBiMDQ0NDEwNDEwMzRhNWUwNDQ3MDVkM2M1YTJjYzMzOGRkNGJmYzNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUZWphc3dpIFRhbmlrZWxsYSA8dGVqYXN3aXRAY29kZWF1cm9y YS5vcmc+CkRhdGU6IFRodSwgMjkgTWFyIDIwMTggMTQ6NDY6NDEgKzA1MzAKU3ViamVjdDogW1BB VENIXSBzbGlwOiBDaGVjayBpZiByc3RhdGUgaXMgaW5pdGlhbGl6ZWQgYmVmb3JlIHVuY29tcHJl c3NpbmcKCk9uIHJlY2VpdmluZyBhIHBhY2tldCB0aGUgc3RhdGUgaW5kZXggcG9pbnRzIHRvIHRo ZSByc3RhdGUgd2hpY2ggbXVzdCBiZQp1c2VkIHRvIGZpbGwgdXAgSVAgYW5kIFRDUCBoZWFkZXJz LiBCdXQgaWYgdGhlIHN0YXRlIGluZGV4IHBvaW50cyB0byBhCnJzdGF0ZSB3aGljaCBpcyB1bml0 aWFsaXplZCwgaS5lLiBmaWxsZWQgd2l0aCB6ZXJvcywgaXQgZ2V0cyBzdHVjayBpbiBhbgppbmZp bml0ZSBsb29wIGluc2lkZSBpcF9mYXN0X2NzdW0gdHJ5aW5nIHRvIGNvbXB1dGUgdGhlIGlwIGNo ZWNzdW0gb2YgYQpoZWFkZXIgd2l0aCB6ZXJvIGxlbmd0aC4KCjg5LjY2Njk1MzogICA8Mj4gWzxm ZmZmZmY5ZGQzZTk0ZDM4Pl0gc2xoY191bmNvbXByZXNzKzB4NDY0LzB4NDY4Cjg5LjY2Njk2NTog ICA8Mj4gWzxmZmZmZmY5ZGQzZTg3ZDg4Pl0gcHBwX3JlY2VpdmVfbm9ubXBfZnJhbWUrMHgzYjQv MHg2NWMKODkuNjY2OTc4OiAgIDwyPiBbPGZmZmZmZjlkZDNlODlkZDQ+XSBwcHBfcmVjZWl2ZV9m cmFtZSsweDY0LzB4N2UwCjg5LjY2Njk5MTogICA8Mj4gWzxmZmZmZmY5ZGQzZThhNzA4Pl0gcHBw X2lucHV0KzB4MTA0LzB4MTk4Cjg5LjY2NzAwNTogICA8Mj4gWzxmZmZmZmY5ZGQzZTkzODY4Pl0g cHBwb3Buc19yZWN2X2NvcmUrMHgyMzgvMHgzNzAKODkuNjY3MDI3OiAgIDwyPiBbPGZmZmZmZjlk ZDQ0MjhmYzg+XSBfX3NrX3JlY2VpdmVfc2tiKzB4ZGMvMHgyNTAKODkuNjY3MDQwOiAgIDwyPiBb PGZmZmZmZjlkZDNlOTM5ZTQ+XSBwcHBvcG5zX3JlY3YrMHg0NC8weDYwCjg5LjY2NzA1MzogICA8 Mj4gWzxmZmZmZmY5ZGQ0NDI2ODQ4Pl0gX19zb2NrX3F1ZXVlX3Jjdl9za2IrMHgxNmMvMHgyNGMK ODkuNjY3MDY1OiAgIDwyPiBbPGZmZmZmZjlkZDQ0MjY5NTQ+XSBzb2NrX3F1ZXVlX3Jjdl9za2Ir MHgyYy8weDM4Cjg5LjY2NzA4NTogICA8Mj4gWzxmZmZmZmY5ZGQ0NGY3MzU4Pl0gcmF3X3Jjdisw eDEyNC8weDE1NAo4OS42NjcwOTg6ICAgPDI+IFs8ZmZmZmZmOWRkNDRmNzU2OD5dIHJhd19sb2Nh bF9kZWxpdmVyKzB4MWUwLzB4MjJjCjg5LjY2NzExNzogICA8Mj4gWzxmZmZmZmY5ZGQ0NGM4YmEw Pl0gaXBfbG9jYWxfZGVsaXZlcl9maW5pc2grMHg3MC8weDI0Ywo4OS42NjcxMzE6ICAgPDI+IFs8 ZmZmZmZmOWRkNDRjOTJmND5dIGlwX2xvY2FsX2RlbGl2ZXIrMHgxMDAvMHgxMGMKCi4vc2NyaXB0 cy9mYWRkcjJsaW5lIHZtbGludXggc2xoY191bmNvbXByZXNzKzB4NDY0LzB4NDY4IG91dHB1dDoK IGlwX2Zhc3RfY3N1bSBhdCBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL2NoZWNrc3VtLmg6NDAKIChp bmxpbmVkIGJ5KSBzbGhjX3VuY29tcHJlc3MgYXQgZHJpdmVycy9uZXQvc2xpcC9zbGhjLmM6NjE1 CgpBZGRpbmcgYSB2YXJpYWJsZSB0byBpbmRpY2F0ZSBpZiB0aGUgY3VycmVudCByc3RhdGUgaXMg aW5pdGlhbGl6ZWQuIElmCnN1Y2ggYSBwYWNrZXQgYXJyaXZlcywgbW92ZSB0byB0b3NzIHN0YXRl LgoKU2lnbmVkLW9mZi1ieTogVGVqYXN3aSBUYW5pa2VsbGEgPHRlamFzd2l0QGNvZGVhdXJvcmEu b3JnPgotLS0KIGRyaXZlcnMvbmV0L3NsaXAvc2xoYy5jIHwgNSArKysrKwogaW5jbHVkZS9uZXQv c2xoY192ai5oICAgfCAxICsKIDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvZHJpdmVycy9uZXQvc2xpcC9zbGhjLmMgYi9kcml2ZXJzL25ldC9zbGlwL3NsaGMu YwppbmRleCA1NzgyNzMzLi5mNGU5M2Y1IDEwMDY0NAotLS0gYS9kcml2ZXJzL25ldC9zbGlwL3Ns aGMuYworKysgYi9kcml2ZXJzL25ldC9zbGlwL3NsaGMuYwpAQCAtNTA5LDYgKzUwOSwxMCBAQCBz dHJ1Y3Qgc2xjb21wcmVzcyAqCiAJCWlmKHggPCAwIHx8IHggPiBjb21wLT5yc2xvdF9saW1pdCkK IAkJCWdvdG8gYmFkOwogCisJCS8qIENoZWNrIGlmIHRoZSBjc3RhdGUgaXMgaW5pdGlhbGl6ZWQg Ki8KKwkJaWYgKCFjb21wLT5yc3RhdGVbeF0uaW5pdGlhbGl6ZWQpCisJCQlnb3RvIGJhZDsKKwog CQljb21wLT5mbGFncyAmPX4gU0xGX1RPU1M7CiAJCWNvbXAtPnJlY3ZfY3VycmVudCA9IHg7CiAJ fSBlbHNlIHsKQEAgLTY3Myw2ICs2NzcsNyBAQCBzdHJ1Y3Qgc2xjb21wcmVzcyAqCiAJaWYgKGNz LT5jc190Y3AuZG9mZiA+IDUpCiAJICBtZW1jcHkoY3MtPmNzX3RjcG9wdCwgaWNwICsgaWhsKjQg KyBzaXplb2Yoc3RydWN0IHRjcGhkciksIChjcy0+Y3NfdGNwLmRvZmYgLSA1KSAqIDQpOwogCWNz LT5jc19oc2l6ZSA9IGlobCoyICsgY3MtPmNzX3RjcC5kb2ZmKjI7CisJY3MtPmluaXRpYWxpemVk ID0gdHJ1ZTsKIAkvKiBQdXQgaGVhZGVycyBiYWNrIG9uIHBhY2tldAogCSAqIE5laXRoZXIgaGVh ZGVyIGNoZWNrc3VtIGlzIHJlY2FsY3VsYXRlZAogCSAqLwpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9u ZXQvc2xoY192ai5oIGIvaW5jbHVkZS9uZXQvc2xoY192ai5oCmluZGV4IDg3MTZkNTkuLjhmY2Y4 OTAgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUvbmV0L3NsaGNfdmouaAorKysgYi9pbmNsdWRlL25ldC9z bGhjX3ZqLmgKQEAgLTEyNyw2ICsxMjcsNyBAQAogICovCiBzdHJ1Y3QgY3N0YXRlIHsKIAlieXRl X3QJY3NfdGhpczsJLyogY29ubmVjdGlvbiBpZCBudW1iZXIgKHhtaXQpICovCisJYm9vbAlpbml0 aWFsaXplZDsJLyogdHJ1ZSBpZiBpbml0aWFsaXplZCAqLwogCXN0cnVjdCBjc3RhdGUgKm5leHQ7 CS8qIG5leHQgaW4gcmluZyAoeG1pdCkgKi8KIAlzdHJ1Y3QgaXBoZHIgY3NfaXA7CS8qIGlwL3Rj cCBoZHIgZnJvbSBtb3N0IHJlY2VudCBwYWNrZXQgKi8KIAlzdHJ1Y3QgdGNwaGRyIGNzX3RjcDsK LS0gCjEuOS4xCgo= --=_db13bcc130a1f3eb01d8d15e1c365439--