From: Gokul Sivakumar <gokulkumar792@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb"
Date: Sun, 15 Aug 2021 00:16:12 +0530 [thread overview]
Message-ID: <ed7f6a42edb01c203e1d6321124184820a23f1d0.camel@gmail.com> (raw)
In-Reply-To: <20210814092231.23513631@hermes.local>
On Sat, 2021-08-14 at 09:22 -0700, Stephen Hemminger wrote:
> On Sat, 14 Aug 2021 15:24:38 +0530
> Gokul Sivakumar <gokulkumar792@gmail.com> wrote:
>
> > + if (!filter_index && r->ndm_ifindex) {
> > + if (!is_json_context())
> > + fprintf(fp, "dev ");
>
> This looks functionally correct, but please use:
> print_string(PRINT_FP, NULL, "dev ", NULL);
>
> The reason as part of the json conversions I look for fprintf(fp
> as indicator of unconverted code.
Ok, thanks for the review. I will send an updated v2 patchset now
with the 2 newly added fprintf() calls replaced by print_string().
next prev parent reply other threads:[~2021-08-14 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 9:54 [PATCH iproute2-next 0/3] bridge: fixes regarding the colorized output Gokul Sivakumar
2021-08-14 9:54 ` [PATCH iproute2-next 1/3] bridge: reorder cmd line arg parsing to let "-c" detected as "color" option Gokul Sivakumar
2021-08-14 9:54 ` [PATCH iproute2-next 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb" Gokul Sivakumar
2021-08-14 16:22 ` Stephen Hemminger
2021-08-14 18:46 ` Gokul Sivakumar [this message]
2021-08-14 9:54 ` [PATCH iproute2-next 3/3] man: bridge: fix the typo to change "-c[lor]" into "-c[olor]" in man page Gokul Sivakumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed7f6a42edb01c203e1d6321124184820a23f1d0.camel@gmail.com \
--to=gokulkumar792@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).