From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver Date: Wed, 20 Jun 2018 10:58:26 -0700 Message-ID: References: <1528974690-31600-1-git-send-email-ilias.apalodimas@linaro.org> <1528974690-31600-5-git-send-email-ilias.apalodimas@linaro.org> <20180618161627.GC5865@lunn.ch> <20180618201940.GA5890@apalos> <671c83ea-6227-cc09-e604-14cfa6804726@redhat.com> <20180620175128.GA27235@apalos> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Andrew Lunn , netdev@vger.kernel.org, grygorii.strashko@ti.com, ivan.khoronzhuk@linaro.org, nsekhar@ti.com, jiri@resnulli.us, francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com, Jose.Abreu@synopsys.com To: Ilias Apalodimas , Ivan Vecera Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:39970 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754199AbeFTR6f (ORCPT ); Wed, 20 Jun 2018 13:58:35 -0400 Received: by mail-qt0-f195.google.com with SMTP id q6-v6so416488qtn.7 for ; Wed, 20 Jun 2018 10:58:35 -0700 (PDT) In-Reply-To: <20180620175128.GA27235@apalos> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/20/2018 10:51 AM, Ilias Apalodimas wrote: > Hello Ivan, > On Wed, Jun 20, 2018 at 02:56:48PM +0200, Ivan Vecera wrote: >> On 18.6.2018 22:19, Ilias Apalodimas wrote: >>> Jiri proposed using devlink, which makes sense, but i am not sure it's >>> applicable on this patchset. This will change the driver completely and will >>> totally break backwards compatibility. >> >> Another good reason for a new driver. >> >> I. > This is actually conflicting at least to my understanding. Jiri proposed using > devlink was used as an alternative method to enable a new mode instead of > adding it on a .config option. A new driver wouldn't have a need for that right? Correct, with a new driver would likely behave correctly upon being probed such that you could have your switch ports act as normal network devices from which you could run IP-config and do NFS boot. -- Florian