From: David Laight <David.Laight@ACULAB.COM>
To: 'David Miller' <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bruce.w.allan@intel.com" <bruce.w.allan@intel.com>,
"jeffrey.e.pieper@intel.com" <jeffrey.e.pieper@intel.com>,
"jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>
Subject: RE: [PATCH net 1/1] e1000e: Stop tx/rx setup spinning for upwards of 300us.
Date: Wed, 4 Mar 2020 09:44:08 +0000 [thread overview]
Message-ID: <ee1f7e3e088e49478734d46dfcb8deb8@AcuMS.aculab.com> (raw)
In-Reply-To: <20200303.160206.1467881674346759532.davem@davemloft.net>
From: David Miller
> Sent: 04 March 2020 00:02
>
> I'll let the Intel folks review and integrate this as it's a
> non-trivial change honestly.
Unfortunately I don't think anyone else properly reviewed the
original patch.
I suspect the real fix is to do a readback and rewrite.
(Assuming the hardware is ignoring the writes.)
For the 'interrupt enable' write, possibly get a reschedule
of the poll function by pretending there is more in the rx ring.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-03-04 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 17:06 [PATCH net 1/1] e1000e: Stop tx/rx setup spinning for upwards of 300us David Laight
2020-03-04 0:02 ` David Miller
2020-03-04 9:44 ` David Laight [this message]
2020-03-04 18:03 ` Jeff Kirsher
2020-03-26 11:08 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee1f7e3e088e49478734d46dfcb8deb8@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.e.pieper@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).