From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Parameswaran Subject: Re: [PATCH 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360. Date: Mon, 24 Apr 2017 16:03:40 -0700 Message-ID: References: <20170424215022.30382-1-eric@anholt.net> <20170424215022.30382-2-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Ray Jui , Scott Branden , Jon Mason To: Eric Anholt , Florian Fainelli , Vivien Didelot , Andrew Lunn , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <20170424215022.30382-2-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Eric A comment on the Device ID. On 17-04-24 02:50 PM, Eric Anholt wrote: > Cygnus is a small family of SoCs, of which we currently have > devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the > same as 58xx, just requiring a tiny bit of setup that was previously > missing. > > Signed-off-by: Eric Anholt > --- > Documentation/devicetree/bindings/net/dsa/b53.txt | 3 +++ > drivers/net/dsa/b53/b53_srab.c | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt > index d6c6e41648d4..49c93d3c0839 100644 > --- a/Documentation/devicetree/bindings/net/dsa/b53.txt > +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt > @@ -29,6 +29,9 @@ Required properties: > "brcm,bcm58625-srab" > "brcm,bcm88312-srab" and the mandatory "brcm,nsp-srab string > > + For the BCM11360 SoC, must be: > + "brcm,bcm11360-srab" and the mandatory "brcm,cygnus-srab string > + > For the BCM63xx/33xx SoCs with an integrated switch, must be one of: > "brcm,bcm3384-switch" > "brcm,bcm6328-switch" > diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c > index 8a62b6a69703..c37ffd1b6833 100644 > --- a/drivers/net/dsa/b53/b53_srab.c > +++ b/drivers/net/dsa/b53/b53_srab.c > @@ -364,6 +364,7 @@ static const struct of_device_id b53_srab_of_match[] = { > { .compatible = "brcm,bcm53018-srab" }, > { .compatible = "brcm,bcm53019-srab" }, > { .compatible = "brcm,bcm5301x-srab" }, > + { .compatible = "brcm,bcm11360-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm58522-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm58525-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm58535-srab", .data = (void *)BCM58XX_DEVICE_ID }, > @@ -371,6 +372,7 @@ static const struct of_device_id b53_srab_of_match[] = { > { .compatible = "brcm,bcm58623-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm58625-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm88312-srab", .data = (void *)BCM58XX_DEVICE_ID }, > + { .compatible = "brcm,cygnus-srab", .data = (void *)BCM58XX_DEVICE_ID }, The device ID should be 0xd300. This is the actual value read from the switch regs. This also requires an entry in the 'b53_switch_chips' structure in b53_common.c. > { .compatible = "brcm,nsp-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { /* sentinel */ }, > }; Other wise this patch set looks good. I was testing a similar change (except for the above, which doesn't affect the functionality) to get the switch working and it works. Thanks Arun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html