From: Eric Dumazet <eric.dumazet@gmail.com>
To: Frank van der Linden <fllinden@amazon.com>,
edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3] tcp: verify the checksum of the first data segment in a new connection
Date: Tue, 12 Jun 2018 21:45:35 -0700 [thread overview]
Message-ID: <ee28187d-61d0-5989-4f16-2133a9d080a7@gmail.com> (raw)
In-Reply-To: <5b2052b1.eyFJo5VnqmUbz/O6%fllinden@amazon.com>
On 06/12/2018 04:09 PM, Frank van der Linden wrote:
> commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash
> table") introduced an optimization for the handling of child sockets
> created for a new TCP connection.
>
> But this optimization passes any data associated with the last ACK of the
> connection handshake up the stack without verifying its checksum, because it
> calls tcp_child_process(), which in turn calls tcp_rcv_state_process()
> directly. These lower-level processing functions do not do any checksum
> verification.
>
> Insert a tcp_checksum_complete call in the TCP_NEW_SYN_RECEIVE path to
> fix this.
>
> Signed-off-by: Frank van der Linden <fllinden@amazon.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Thanks !
next prev parent reply other threads:[~2018-06-13 4:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 23:09 [PATCH v3] tcp: verify the checksum of the first data segment in a new connection Frank van der Linden
2018-06-13 4:45 ` Eric Dumazet [this message]
2018-06-13 5:10 ` Balbir Singh
2018-06-15 0:05 ` David Miller
2018-06-15 15:32 ` van der Linden, Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee28187d-61d0-5989-4f16-2133a9d080a7@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=fllinden@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).