From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v3] tcp: verify the checksum of the first data segment in a new connection Date: Tue, 12 Jun 2018 21:45:35 -0700 Message-ID: References: <5b2052b1.eyFJo5VnqmUbz/O6%fllinden@amazon.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Frank van der Linden , edumazet@google.com, netdev@vger.kernel.org Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:42202 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754328AbeFMEpi (ORCPT ); Wed, 13 Jun 2018 00:45:38 -0400 Received: by mail-pf0-f195.google.com with SMTP id w7-v6so701675pfn.9 for ; Tue, 12 Jun 2018 21:45:37 -0700 (PDT) In-Reply-To: <5b2052b1.eyFJo5VnqmUbz/O6%fllinden@amazon.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/12/2018 04:09 PM, Frank van der Linden wrote: > commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash > table") introduced an optimization for the handling of child sockets > created for a new TCP connection. > > But this optimization passes any data associated with the last ACK of the > connection handshake up the stack without verifying its checksum, because it > calls tcp_child_process(), which in turn calls tcp_rcv_state_process() > directly. These lower-level processing functions do not do any checksum > verification. > > Insert a tcp_checksum_complete call in the TCP_NEW_SYN_RECEIVE path to > fix this. > > Signed-off-by: Frank van der Linden Signed-off-by: Eric Dumazet Thanks !