From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BAB3E547 for ; Tue, 18 Jul 2023 09:27:21 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20AD010C2 for ; Tue, 18 Jul 2023 02:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689672438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z0vyMeOfw7fSC/qxKnZBBj+xlz8lL8pZMksMNnnuzCg=; b=K7TqF0DNUlcG9za22J4Zz7DRxNCZQ3nix1UAh2gErwSgekXMLIhPvNGwNCQqqTFyNMdwhy etWVYGfmGf6QJaOGaHpOHCzwxkezWulucN8FEtJUtDoprmEn3RA4SZglG0Xt8+fe/Ddwi5 FG/j3EbMWqoPAJ0KlAKvKiRo6VXdn0A= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-tRY0rGf4MP2Lbh-BWFpeNQ-1; Tue, 18 Jul 2023 05:27:16 -0400 X-MC-Unique: tRY0rGf4MP2Lbh-BWFpeNQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-63c9463c116so5251356d6.0 for ; Tue, 18 Jul 2023 02:27:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689672436; x=1690277236; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=z0vyMeOfw7fSC/qxKnZBBj+xlz8lL8pZMksMNnnuzCg=; b=hdzUDaJ7F74z6GBUP9sWZ0c9Ydg9T+IQ3diSHoWOgfvd0lNgnuZzExJWTVhx91JkR3 /AO3XAyNFqbNvaUXiqKV507jGj1hMga93s2eM/3FT2esY2bVhTyDOAvDeHLLiRnjAxUH iubX+5VkGq7mtjmkAzZuAcqbCTjnOYDz/9TGbC2bm7zDxEnDHF95eXONkiGfiKbJKK/w I+msa6f3YKJr+Pw6wXK74hBTfSiMHUtLztwXnL+/lVQGTXEDb8pfAui+1Im4lie2RtBt Kz4LlBWsVZpl7SM1WymJkFVny227R3SY9B9zze/Q08/wRYpUx59GFo39GahY615VAd96 hKkQ== X-Gm-Message-State: ABy/qLZV0zeB8McV7eANO3tV9x2to7pATgbtCTVNtfc+sRX66tnHgipT M3sXVdlQDhHiVasUIj1KgjOqpfGxxsXuif22MuWR7n0Ytyon2VKO3SGrX3KR9daSoajVhcEws5g U+lIkIJTpMskAmZ6M X-Received: by 2002:a05:6214:509d:b0:63c:7427:e7e9 with SMTP id kk29-20020a056214509d00b0063c7427e7e9mr12261335qvb.6.1689672436175; Tue, 18 Jul 2023 02:27:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFYFNw7x3jThmvZICEe6iXFu0qG+zQql7vEpRKMvc0qVPxJUK7o8zW+ji84Z85dUEkIw+qD2g== X-Received: by 2002:a05:6214:509d:b0:63c:7427:e7e9 with SMTP id kk29-20020a056214509d00b0063c7427e7e9mr12261327qvb.6.1689672435965; Tue, 18 Jul 2023 02:27:15 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-226-170.dyn.eolo.it. [146.241.226.170]) by smtp.gmail.com with ESMTPSA id h10-20020a0cf20a000000b00635fc10afd6sm592785qvk.70.2023.07.18.02.27.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 02:27:15 -0700 (PDT) Message-ID: Subject: Re: [PATCH] net: Explicitly include correct DT includes From: Paolo Abeni To: Alex Elder , Rob Herring , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Alex Elder Cc: devicetree@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-mediatek@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-amlogic@lists.infradead.org, linux-oxnas@groups.io, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-wpan@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, wcn36xx@lists.infradead.org Date: Tue, 18 Jul 2023 11:27:10 +0200 In-Reply-To: <1c6175fc-496a-843c-c8c5-2173e065eaa8@ieee.org> References: <20230714174809.4060885-1-robh@kernel.org> <1c6175fc-496a-843c-c8c5-2173e065eaa8@ieee.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi, On Sat, 2023-07-15 at 10:11 -0500, Alex Elder wrote: > On 7/14/23 12:48 PM, Rob Herring wrote: > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it as merged into the regular platform bus. > > As part of that merge prepping Arm DT support 13 years ago, they > > "temporarily" include each other. They also include platform_device.h > > and of.h. As a result, there's a pretty much random mix of those includ= e > > files used throughout the tree. In order to detangle these headers and > > replace the implicit includes with struct declarations, users need to > > explicitly include the correct includes. > >=20 > > Signed-off-by: Rob Herring >=20 > (I significantly reduced the addressee list to permit the message > to be sent.) >=20 > For "drivers/net/ipa/ipa_main.c": >=20 > Acked-by: Alex Elder The patch does not apply cleanly to net-next. Rob, could you please re- spin it? While at that, have you considered splitting it in a few smaller patches (e.g. can, dsa, freescale, ibm, marvel, mediatek, stmmicro, sun, ti, xilinx, wireless, remaining)? Thanks! Paolo