netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] wlwifi: mei: Fix build error without CFG80211
@ 2022-03-18  3:01 YueHaibing
  2022-03-18  4:03 ` YueHaibing
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2022-03-18  3:01 UTC (permalink / raw)
  To: luciano.coelho, kvalo, davem, kuba, pabeni, ayala.beker,
	emmanuel.grumbach
  Cc: linux-wireless, netdev, linux-kernel, YueHaibing

If CFG80211 is n and IWLMEI is y,  building fails:

drivers/net/wireless/intel/iwlwifi/mei/net.o: In function `iwl_mei_tx_copy_to_csme':
net.c:(.text+0xd0): undefined reference to `ieee80211_hdrlen'

Make IWLMEI depends on CFG80211 to fix this.

Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index 85e704283755..8c003cd29ab7 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -137,7 +137,7 @@ endif
 
 config IWLMEI
 	tristate "Intel Management Engine communication over WLAN"
-	depends on INTEL_MEI
+	depends on INTEL_MEI && CFG80211
 	depends on PM
 	help
 	  Enables the iwlmei kernel module.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] wlwifi: mei: Fix build error without CFG80211
  2022-03-18  3:01 [PATCH -next] wlwifi: mei: Fix build error without CFG80211 YueHaibing
@ 2022-03-18  4:03 ` YueHaibing
  0 siblings, 0 replies; 2+ messages in thread
From: YueHaibing @ 2022-03-18  4:03 UTC (permalink / raw)
  To: luciano.coelho, kvalo, davem, kuba, pabeni, ayala.beker,
	emmanuel.grumbach
  Cc: linux-wireless, netdev, linux-kernel

On 2022/3/18 11:01, YueHaibing wrote:
> If CFG80211 is n and IWLMEI is y,  building fails:
> 
> drivers/net/wireless/intel/iwlwifi/mei/net.o: In function `iwl_mei_tx_copy_to_csme':
> net.c:(.text+0xd0): undefined reference to `ieee80211_hdrlen'
> 
> Make IWLMEI depends on CFG80211 to fix this.
> 

It seems has been fixed, Pls igbore this.

> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 85e704283755..8c003cd29ab7 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -137,7 +137,7 @@ endif
>  
>  config IWLMEI
>  	tristate "Intel Management Engine communication over WLAN"
> -	depends on INTEL_MEI
> +	depends on INTEL_MEI && CFG80211
>  	depends on PM
>  	help
>  	  Enables the iwlmei kernel module.
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-18  4:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-18  3:01 [PATCH -next] wlwifi: mei: Fix build error without CFG80211 YueHaibing
2022-03-18  4:03 ` YueHaibing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).