From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA742F12A5; Tue, 7 Jul 2026 19:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783451052; cv=none; b=Av2hn8XpY0AWvz3sXYz4K+2f6dhlXgqkY6NMgM2IfjoMayUHK0mBJp6h89QXExhzH0skf0TKXDQkwEQ1qIilX6Gsc6mQ1arj0/CwKyi2niXj0gwMVeHUTbp3TCxHkVUKooXBOHbiBuLKZzMSDPlTrNdmzB309aWf3EOUhE0DpHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783451052; c=relaxed/simple; bh=6bbEwg9cHivlDdMKiwEt9gzMXBhcZhTNsBXne4l4+lI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h/GKh3I9uCbQ8nGMbPx9ygYE168sWBk9SXwOBzpsX5vj4kLHjAlyxw6Mi3MAdjkzpDV9owfj79561gsTYAmFzTiznaScc3NUGHDIurWnBXcD/t0TTpuhPjhmpbArHzbbHFTCexfqgs2ortr9W/LGpU5CPhvyRvXy+ClF6IMBBFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=VWrd41qR; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="VWrd41qR" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=avVeJSV3sTgrfABYepnBzlTH2P7OWGaspJVsPup+ruw=; b=VWrd41qRXyYyhzMWp+gqpuvhbS 6B85dG3uLp6arQ3/pkhJsCYGOR87TGtYdSF/I8ogvfumgVQ+vAm6bt5SSlqyIbW5lG6tfBBjIVX5y UOGorZW+Dpd8xlk1kNS3h4bBcNBO9GNoOUkvUW+Rvcix7+8IviZrKFkh3/um8eIUf8sc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1whB5M-00BDMh-PC; Tue, 07 Jul 2026 21:04:00 +0200 Date: Tue, 7 Jul 2026 21:04:00 +0200 From: Andrew Lunn To: Jakub Raczynski Cc: netdev@vger.kernel.org, k.tegowski@samsung.com, k.domagalski@samsung.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 2/2] net/stmmac: Verify provided DTS AXI setup Message-ID: References: <20260707174431.1264520-1-j.raczynski@samsung.com> <20260707174431.1264520-3-j.raczynski@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260707174431.1264520-3-j.raczynski@samsung.com> On Tue, Jul 07, 2026 at 07:44:31PM +0200, Jakub Raczynski wrote: > During parsing of AXI setup, there are few issues: > - 'axi_blen' array is uninitialized value on stack without zero-init stack > configured. This can result in random AXI burst length config if > DTS config provides shorter array than AXI_BLEN. What does the DT blinding say about the length? Is it allowed to be short? Are we talking about: snps,blen: $ref: /schemas/types.yaml#/definitions/uint32-array description: this is a vector of supported burst length. minItems: 7 maxItems: 7 So it should be 7. Are there any in kernel DT blobs which don't pass 7? Can we just error out when it is not 7? > - In case of failed memory allocation for AXI and error, there is no handling > of that. Fix it by checking if AXI config is error and return if so, > as this can only lack of memory. No AXI config, although is probably > wrong in most cases, is not treated as error, as generic config is mostly > provided in drivers. This seems like a different fix. Maybe put it into a patch of its own. > Fixes: afea03656add ("stmmac: rework DMA bus setting and introduce new platform AXI structure") Again, does this bother anybody? At least axi_blen issue seems to be that the DT blob is broken, so i doubt it actually does. Are there reports of memory allocation error and resulting Opps. Andrew --- pw-bot: cr