From: Tilman Schmidt <tilman@imap.cc>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
Hansjoerg Lipp <hjlipp@web.de>,
Karsten Keil <isdn@linux-pingi.de>,
isdn4linux@listserv.isdn4linux.de
Subject: [PATCH 1/4] isdn/gigaset: improve error handling when leaving DLE mode
Date: Fri, 3 Oct 2014 17:03:32 +0200 [thread overview]
Message-ID: <ee511dbac1d1f24f8ad8b7b15ec3047cc785ae08.1412348612.git.tilman@imap.cc> (raw)
In-Reply-To: <cover.1412348612.git.tilman@imap.cc>
Avoid cascading warnings when leaving DLE mode fails by clearing
the DLE flag before entering recovery.
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---
drivers/isdn/gigaset/ev-layer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c
index 7459b12..dcae14a 100644
--- a/drivers/isdn/gigaset/ev-layer.c
+++ b/drivers/isdn/gigaset/ev-layer.c
@@ -1243,7 +1243,8 @@ static void do_action(int action, struct cardstate *cs,
break;
case ACT_FAILDLE0:
cs->cur_at_seq = SEQ_NONE;
- dev_warn(cs->dev, "Could not leave DLE mode.\n");
+ dev_warn(cs->dev, "Error leaving DLE mode.\n");
+ cs->dle = 0;
at_state2 = &cs->bcs[cs->curchannel].at_state;
disconnect(&at_state2);
schedule_init(cs, MS_RECOVER);
--
1.9.2.459.g68773ac
next prev parent reply other threads:[~2014-10-03 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 15:03 [PATCH 0/4] ISDN patches for net-next Tilman Schmidt
2014-10-03 15:03 ` Tilman Schmidt [this message]
2014-10-03 15:03 ` [PATCH 4/4] isdn/capi: drop two dead if branches Tilman Schmidt
2014-10-03 15:03 ` [PATCH 3/4] isdn/gigaset: use USB API function usb_endpoint_num() Tilman Schmidt
2014-10-03 15:03 ` [PATCH 2/4] isdn/gigaset: drop unused cardstate structure member Tilman Schmidt
2014-10-06 1:18 ` [PATCH 0/4] ISDN patches for net-next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee511dbac1d1f24f8ad8b7b15ec3047cc785ae08.1412348612.git.tilman@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).