From: Florian Fainelli <f.fainelli@gmail.com>
To: Mattias Forsblad <mattias.forsblad@gmail.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches.
Date: Fri, 9 Sep 2022 10:34:35 -0700 [thread overview]
Message-ID: <ee6ac1f4-4c80-948e-4711-7e7843329a16@gmail.com> (raw)
In-Reply-To: <20220909085138.3539952-2-mattias.forsblad@gmail.com>
On 9/9/2022 1:51 AM, Mattias Forsblad wrote:
> Add RMU enable functionality for some Marvell SOHO switches.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
No need for newline here.
>
> Signed-off-by: Mattias Forsblad <mattias.forsblad@gmail.com>
Just one nit, sorry about that:
[snip]
> index e693154cf803..7ce3c41f6caf 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.h
> +++ b/drivers/net/dsa/mv88e6xxx/chip.h
> @@ -637,6 +637,7 @@ struct mv88e6xxx_ops {
>
> /* Remote Management Unit operations */
> int (*rmu_disable)(struct mv88e6xxx_chip *chip);
> + int (*rmu_enable)(struct mv88e6xxx_chip *chip, int port);
Change the argument name to upstream_port to match the implementation
for each chip that you are adding?
--
Florian
next prev parent reply other threads:[~2022-09-09 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 8:51 [PATCH net-next v8 0/6] net: dsa: qca8k, mv88e6xxx: rmon: Add RMU support Mattias Forsblad
2022-09-09 8:51 ` [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches Mattias Forsblad
2022-09-09 17:34 ` Florian Fainelli [this message]
2022-09-11 12:19 ` Vladimir Oltean
2022-09-09 8:51 ` [PATCH net-next v8 2/6] net: dsa: Add convenience functions for frame handling Mattias Forsblad
2022-09-11 13:27 ` Vladimir Oltean
2022-09-09 8:51 ` [PATCH net-next v8 3/6] net: dsa: Introduce dsa tagger data operation Mattias Forsblad
2022-09-09 17:35 ` Florian Fainelli
2022-09-11 13:46 ` Vladimir Oltean
2022-09-09 8:51 ` [PATCH net-next v8 4/6] net: dsa: mv88e6xxxx: Add RMU functionality Mattias Forsblad
2022-09-09 13:43 ` kernel test robot
2022-09-11 14:11 ` Vladimir Oltean
2022-09-09 8:51 ` [PATCH net-next v8 5/6] net: dsa: mv88e6xxx: rmon: Use RMU for reading RMON data Mattias Forsblad
2022-09-09 8:51 ` [PATCH net-next v8 6/6] net: dsa: qca8k: Use new convenience functions Mattias Forsblad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6ac1f4-4c80-948e-4711-7e7843329a16@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mattias.forsblad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).