From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf-next] bpf: prevent non-IPv4 socket to be added into sock hash Date: Fri, 1 Jun 2018 00:56:11 -0700 Message-ID: References: <20180530212928.190650-1-tracywwnj@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Wei Wang , netdev , Willem de Bruijn To: Eric Dumazet Return-path: Received: from mail-io0-f195.google.com ([209.85.223.195]:34884 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbeFAH4b (ORCPT ); Fri, 1 Jun 2018 03:56:31 -0400 Received: by mail-io0-f195.google.com with SMTP id u4-v6so5003821iof.2 for ; Fri, 01 Jun 2018 00:56:31 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/31/2018 06:00 PM, Eric Dumazet wrote: > On Thu, May 31, 2018 at 7:32 PM John Fastabend wrote: >> >> >> Hi Wei, >> >> Thanks for the report and fix. It would be better to fix the >> root cause so that IPv6 works as intended. >> >> I'm testing the following now, >> >> Author: John Fastabend >> Date: Thu May 31 14:38:59 2018 -0700 >> >> sockmap: fix crash when ipv6 sock is added by adding support for IPv6 >> >> Apparently we had a testing escape and missed IPv6. This fixes a crash >> where we assign tcp_prot to IPv6 sockets instead of tcpv6_prot. >> >> Signed-off-by: John Fastabend >> > > Hi John > > In any case, please forward correct attribution for Wei's work, and > syzbot 'Reported-by' Will send update with tags in a moment. > > Are you sure you are handling IPv4 mapped in IPv6 sockets as well ? > No, will look into it. Although I didn't see any code to handle it in the ./net/tls case either so if there is some issue with this it could possibly exist in both ULPs. I guess if ipv4 mapped ipv6 changes prot or callbacks then we could stomp on it. > Thanks. >