From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata Date: Mon, 22 Jan 2018 19:00:45 +0200 Message-ID: References: <1516639614-12960-1-git-send-email-serhe.popovych@gmail.com> <1516639614-12960-2-git-send-email-serhe.popovych@gmail.com> <20180122175841.71400890@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RZzROFxs4gAVa8iTjDhbbEUqemumyY1IN" Cc: netdev@vger.kernel.org, u9012063@gmail.com, julien@cumulusnetworks.com To: Jiri Benc Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:37417 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbeAVRAx (ORCPT ); Mon, 22 Jan 2018 12:00:53 -0500 Received: by mail-wm0-f68.google.com with SMTP id v71so18241360wmv.2 for ; Mon, 22 Jan 2018 09:00:52 -0800 (PST) In-Reply-To: <20180122175841.71400890@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RZzROFxs4gAVa8iTjDhbbEUqemumyY1IN Content-Type: multipart/mixed; boundary="fF146v4kjrj6BrVjqLNMBeSnwukLtLTey"; protected-headers="v1" From: Serhey Popovych To: Jiri Benc Cc: netdev@vger.kernel.org, u9012063@gmail.com, julien@cumulusnetworks.com Message-ID: Subject: Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata References: <1516639614-12960-1-git-send-email-serhe.popovych@gmail.com> <1516639614-12960-2-git-send-email-serhe.popovych@gmail.com> <20180122175841.71400890@redhat.com> In-Reply-To: <20180122175841.71400890@redhat.com> --fF146v4kjrj6BrVjqLNMBeSnwukLtLTey Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jiri Benc wrote: > On Mon, 22 Jan 2018 18:46:53 +0200, Serhey Popovych wrote: >> + if (tb[IFLA_GRE_COLLECT_METADATA]) { >> + print_bool(PRINT_ANY, "collect_metadata", "external", true); >> + return; >> + } >=20 > Nacked-by: Jiri Benc >=20 > Don't ever use "collect_metadata" for anything visible to the user. >=20 > collect_metadata is a *horrible* name. It describes the internal > implementation of the lwtunneling in the kernel and provides zero > explanation to the user about what's that feature good for. >=20 > The netlink attribute should have never had such name but it's uAPI and= > we have to live with it. But there's no reason to expose this to the > user. >=20 > Stick with the "external" name. It explains what it is about: instead o= f > the traffic being controlled by the tunnel internal logic (or tunnel > control plane, if you want), an external logic needs to be attached to > the tunnel in order for the tunneling to work. Thanks! That's probably what I expect to hear. Will prepare v2 shortly. >=20 > Jiri >=20 --fF146v4kjrj6BrVjqLNMBeSnwukLtLTey-- --RZzROFxs4gAVa8iTjDhbbEUqemumyY1IN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJaZhjCAAoJEBTawMmQ61bBptQIAKzNnoybCj567Z18tVjTORN6 Zx5sKg2Ik119e1tus6SCCz7LhulYdF30v9WFSMUVd98iNIWbu4s6BmnMBOyvqTq7 J78CrvpbGJVB55/3EhaIS21TA6B9DQiAXYy3qWNqALtCKqzm0YqJP0d3fiBwLN0f HyU/AaTc20XuIkjZDZsZZZEuWNTuyKIZDvVMBikMQ3/MF3RLrJuJv6xpGF/zhIsm JHSv62vbGxxjfKNuDSbjVC3peMSMBujY/ouGWwkgn1AzKBDhkwLz7A78kkbkWmNp EzTz+SRfzqJ2ZK4OC6alYVe06ZD6zvBeVoyP5tItjTNyluZce2bcQl6Wjwa6ldk= =jZ9s -----END PGP SIGNATURE----- --RZzROFxs4gAVa8iTjDhbbEUqemumyY1IN--