* [PATCH] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id()
@ 2026-01-09 9:06 Zeng Chi
2026-01-13 5:53 ` Tariq Toukan
2026-01-13 13:21 ` Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: Zeng Chi @ 2026-01-09 9:06 UTC (permalink / raw)
To: saeedm, leon, tariqt, mbloch, andrew+netdev, davem, edumazet,
kuba, pabeni
Cc: netdev, linux-rdma, linux-kernel, zengchi
From: Zeng Chi <zengchi@kylinos.cn>
The function mlx5_esw_vport_vhca_id() is declared to return bool,
but returns -EOPNOTSUPP (-45), which is an int error code. This
causes a signedness bug as reported by smatch.
This patch fixes this smatch report:
drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:981 mlx5_esw_vport_vhca_id()
warn: signedness bug returning '(-45)'
Signed-off-by: Zeng Chi <zengchi@kylinos.cn>
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
index ad1073f7b79f..e7fe43799b23 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
@@ -1009,7 +1009,7 @@ mlx5_esw_host_functions_enabled(const struct mlx5_core_dev *dev)
static inline bool
mlx5_esw_vport_vhca_id(struct mlx5_eswitch *esw, u16 vportn, u16 *vhca_id)
{
- return -EOPNOTSUPP;
+ return false;
}
#endif /* CONFIG_MLX5_ESWITCH */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id()
2026-01-09 9:06 [PATCH] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id() Zeng Chi
@ 2026-01-13 5:53 ` Tariq Toukan
2026-01-13 13:21 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Tariq Toukan @ 2026-01-13 5:53 UTC (permalink / raw)
To: Zeng Chi, saeedm, leon, tariqt, mbloch, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: netdev, linux-rdma, linux-kernel, zengchi
On 09/01/2026 11:06, Zeng Chi wrote:
> From: Zeng Chi <zengchi@kylinos.cn>
>
Thanks for your patch.
Please specify target branch.
> The function mlx5_esw_vport_vhca_id() is declared to return bool,
> but returns -EOPNOTSUPP (-45), which is an int error code. This
> causes a signedness bug as reported by smatch.
>
> This patch fixes this smatch report:
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:981 mlx5_esw_vport_vhca_id()
> warn: signedness bug returning '(-45)'
>
Missing Fixes tag.
> Signed-off-by: Zeng Chi <zengchi@kylinos.cn>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> index ad1073f7b79f..e7fe43799b23 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> @@ -1009,7 +1009,7 @@ mlx5_esw_host_functions_enabled(const struct mlx5_core_dev *dev)
> static inline bool
> mlx5_esw_vport_vhca_id(struct mlx5_eswitch *esw, u16 vportn, u16 *vhca_id)
> {
> - return -EOPNOTSUPP;
> + return false;
> }
>
> #endif /* CONFIG_MLX5_ESWITCH */
Regards,
Tariq
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id()
2026-01-09 9:06 [PATCH] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id() Zeng Chi
2026-01-13 5:53 ` Tariq Toukan
@ 2026-01-13 13:21 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2026-01-13 13:21 UTC (permalink / raw)
To: Zeng Chi, linux-rdma, netdev
Cc: Zeng Chi, LKML, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Leon Romanovsky, Mark Bloch, Paolo Abeni,
Saeed Mahameed, Tariq Toukan
…
> This patch fixes this smatch report:
…
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-13 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 9:06 [PATCH] net/mlx5: Fix return type mismatch in mlx5_esw_vport_vhca_id() Zeng Chi
2026-01-13 5:53 ` Tariq Toukan
2026-01-13 13:21 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox