From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFC0C433EA for ; Wed, 15 Jul 2020 10:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6518C206F5 for ; Wed, 15 Jul 2020 10:04:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gOsLH1Iw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731012AbgGOKE2 (ORCPT ); Wed, 15 Jul 2020 06:04:28 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:40403 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725838AbgGOKE1 (ORCPT ); Wed, 15 Jul 2020 06:04:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594807465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=weZYbeSY39lus+MmvOlHiowxYixXEAHCQmjpqMFvj2c=; b=gOsLH1IwFsvQrrYSwDqyB/V1CynLss6XI5IP+imqUrlm0HryxiCPDjk5/+xxUn6W56scG+ TgeV6TeWuVumqzcUe4nynQFs/+SUB2fy4nMBNoGXQ5JKM2EgA0zlaCDXQdwUusxtPOAKeN O1DQ/USm06S/ef9xVYzKSzrLK9Ndd2o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-RWF5CGyTORe29C-CK25FGA-1; Wed, 15 Jul 2020 06:04:23 -0400 X-MC-Unique: RWF5CGyTORe29C-CK25FGA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A2F8800597; Wed, 15 Jul 2020 10:04:22 +0000 (UTC) Received: from [10.72.13.230] (ovpn-13-230.pek2.redhat.com [10.72.13.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F55B5C1BD; Wed, 15 Jul 2020 10:04:13 +0000 (UTC) Subject: Re: [PATCH 6/7] ifcvf: replace irq_request/free with helpers in vDPA core. To: "Michael S. Tsirkin" Cc: "Zhu, Lingshan" , alex.williamson@redhat.com, pbonzini@redhat.com, sean.j.christopherson@intel.com, wanpengli@tencent.com, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, dan.daly@intel.com References: <1594565366-3195-1-git-send-email-lingshan.zhu@intel.com> <1594565366-3195-6-git-send-email-lingshan.zhu@intel.com> <09e67c20-dda1-97a2-1858-6a543c64fba6@redhat.com> <20200715055538-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: Date: Wed, 15 Jul 2020 18:04:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200715055538-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/7/15 下午6:01, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 04:40:17PM +0800, Jason Wang wrote: >> On 2020/7/13 下午6:22, Zhu, Lingshan wrote: >>> On 7/13/2020 4:33 PM, Jason Wang wrote: >>>> On 2020/7/12 下午10:49, Zhu Lingshan wrote: >>>>> This commit replaced irq_request/free() with helpers in vDPA >>>>> core, so that it can request/free irq and setup irq offloading >>>>> on order. >>>>> >>>>> Signed-off-by: Zhu Lingshan >>>>> --- >>>>>   drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++++++----- >>>>>   1 file changed, 6 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c >>>>> b/drivers/vdpa/ifcvf/ifcvf_main.c >>>>> index f5a60c1..65b84e1 100644 >>>>> --- a/drivers/vdpa/ifcvf/ifcvf_main.c >>>>> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c >>>>> @@ -47,11 +47,12 @@ static void ifcvf_free_irq(struct >>>>> ifcvf_adapter *adapter, int queues) >>>>>   { >>>>>       struct pci_dev *pdev = adapter->pdev; >>>>>       struct ifcvf_hw *vf = &adapter->vf; >>>>> +    struct vdpa_device *vdpa = &adapter->vdpa; >>>>>       int i; >>>>>           for (i = 0; i < queues; i++) >>>>> -        devm_free_irq(&pdev->dev, vf->vring[i].irq, &vf->vring[i]); >>>>> +        vdpa_free_vq_irq(&pdev->dev, vdpa, vf->vring[i].irq, i, >>>>> &vf->vring[i]); >>>>>         ifcvf_free_irq_vectors(pdev); >>>>>   } >>>>> @@ -60,6 +61,7 @@ static int ifcvf_request_irq(struct >>>>> ifcvf_adapter *adapter) >>>>>   { >>>>>       struct pci_dev *pdev = adapter->pdev; >>>>>       struct ifcvf_hw *vf = &adapter->vf; >>>>> +    struct vdpa_device *vdpa = &adapter->vdpa; >>>>>       int vector, i, ret, irq; >>>>>         ret = pci_alloc_irq_vectors(pdev, IFCVF_MAX_INTR, >>>>> @@ -73,6 +75,7 @@ static int ifcvf_request_irq(struct >>>>> ifcvf_adapter *adapter) >>>>>            pci_name(pdev)); >>>>>       vector = 0; >>>>>       irq = pci_irq_vector(pdev, vector); >>>>> +    /* config interrupt */ >>>> Unnecessary changes. >>> This is to show we did not setup this irq offloading for config >>> interrupt, only setup irq offloading for data vq. But can remove this >>> since we have config_msix_name in code to show what it is >> Btw, any reason for not making config interrupt work for irq offloading? I >> don't see any thing that blocks this. >> >> Thanks > Well config accesses all go through userspace right? > Doing config interrupt directly would just be messy ... Right, so I think we need a better comment here. Thanks > >