From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.li@nxp.com>, Stefan Wahren <wahrenst@gmx.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format
Date: Mon, 2 Jun 2025 22:21:30 +0200 [thread overview]
Message-ID: <ef00a8e6-4121-42d2-a752-a3dbd7244f16@kernel.org> (raw)
In-Reply-To: <aD3E2ONB6Ay1wwmk@lizhi-Precision-Tower-5810>
On 02/06/2025 17:35, Frank Li wrote:
>
>>> +
>>> +properties:
>>> + compatible:
>>> + const: qca,qca7000
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + spi-cpha: true
>>> +
>>> + spi-cpol: true
>> In case of a SPI setup these properties should be required. Unfortunately
>> i'm not sure how to enforce this. Maybe depending on the presence of "reg"?
>
> But It think depend on reg is not good idea, which too obscure. Ideally it
> should be use two compatible strings. It should treat as two kinds device.
> It is really old devices and not worth to update compatible string.
>
> Maybe some one in dt team can provide suggestion!
>
> Rob and Krzysztof Kozlowski:
> any idea about this?
You can check for reg and require these, e.g.:
https://elixir.bootlin.com/linux/v6.4-rc7/source/Documentation/devicetree/bindings/net/qcom,ipa.yaml#L191
See also for very similar case:
Documentation/devicetree/bindings/net/dsa/realtek.yaml
However for multi-bus devices we usually do not code such constraints.
Partially because of typical cases - i2c and spi - it would not be possible.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-06-02 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 19:17 [PATCH 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format Frank Li
2025-05-30 8:33 ` Stefan Wahren
2025-06-02 15:35 ` Frank Li
2025-06-02 19:28 ` Stefan Wahren
2025-06-02 20:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef00a8e6-4121-42d2-a752-a3dbd7244f16@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).