From: David Ahern <dsahern@gmail.com>
To: Joe Perches <joe@perches.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
davem@davemloft.net
Cc: netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net] ipv6: route: remove duplicated string from error message
Date: Sun, 13 Jan 2019 09:08:56 -0700 [thread overview]
Message-ID: <ef263d11-a98e-2f9f-f917-7e022b730e6a@gmail.com> (raw)
In-Reply-To: <f19a75a7ddc70b6094bc8da5e738896410e3f4ba.camel@perches.com>
On 1/12/19 2:07 PM, Joe Perches wrote:
> On Sat, 2019-01-12 at 12:45 -0800, Jakub Kicinski wrote:
>> "IPv6: " prefix is already added by pr_fmt, no need to include
>> it again in the pr_warn() format.
> []
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> []
>> @@ -4256,7 +4256,7 @@ static void ip6_print_replace_route_err(struct list_head *rt6_nh_list)
>> struct rt6_nh *nh;
>>
>> list_for_each_entry(nh, rt6_nh_list, next) {
>> - pr_warn("IPV6: multipath route replace failed (check consistency of installed routes): %pI6c nexthop %pI6c ifi %d\n",
>> + pr_warn("multipath route replace failed (check consistency of installed routes): %pI6c nexthop %pI6c ifi %d\n",
>
> Thanks.
>
> Just asking, couldn't this emit a rather long list?
> Perhaps it should be ratelimited?
>
>
That should be converted to an extack message now.
next prev parent reply other threads:[~2019-01-13 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 20:45 [PATCH net] ipv6: route: remove duplicated string from error message Jakub Kicinski
2019-01-12 21:07 ` Joe Perches
2019-01-13 16:08 ` David Ahern [this message]
2019-01-14 18:38 ` Jakub Kicinski
2019-01-14 18:52 ` [PATCH net v2] ipv6: route: place a warning with duplicated string with correct extack Jakub Kicinski
2019-01-16 3:54 ` David Ahern
2019-01-16 22:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef263d11-a98e-2f9f-f917-7e022b730e6a@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).