From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] ipv6: route: remove duplicated string from error message Date: Sun, 13 Jan 2019 09:08:56 -0700 Message-ID: References: <20190112204511.24710-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Roopa Prabhu To: Joe Perches , Jakub Kicinski , davem@davemloft.net Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:37672 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbfAMQJA (ORCPT ); Sun, 13 Jan 2019 11:09:00 -0500 Received: by mail-pg1-f194.google.com with SMTP id c25so8414698pgb.4 for ; Sun, 13 Jan 2019 08:08:59 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/12/19 2:07 PM, Joe Perches wrote: > On Sat, 2019-01-12 at 12:45 -0800, Jakub Kicinski wrote: >> "IPv6: " prefix is already added by pr_fmt, no need to include >> it again in the pr_warn() format. > [] >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > [] >> @@ -4256,7 +4256,7 @@ static void ip6_print_replace_route_err(struct list_head *rt6_nh_list) >> struct rt6_nh *nh; >> >> list_for_each_entry(nh, rt6_nh_list, next) { >> - pr_warn("IPV6: multipath route replace failed (check consistency of installed routes): %pI6c nexthop %pI6c ifi %d\n", >> + pr_warn("multipath route replace failed (check consistency of installed routes): %pI6c nexthop %pI6c ifi %d\n", > > Thanks. > > Just asking, couldn't this emit a rather long list? > Perhaps it should be ratelimited? > > That should be converted to an extack message now.