From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment Date: Mon, 7 May 2018 11:27:01 -0700 Message-ID: References: <20180507180310.3486.35994.stgit@localhost.localdomain> <20180507180840.3486.67728.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Alexander Duyck , netdev@vger.kernel.org, willemb@google.com, davem@davemloft.net Return-path: Received: from mail-pl0-f50.google.com ([209.85.160.50]:43623 "EHLO mail-pl0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbeEGS1C (ORCPT ); Mon, 7 May 2018 14:27:02 -0400 Received: by mail-pl0-f50.google.com with SMTP id a39-v6so269463pla.10 for ; Mon, 07 May 2018 11:27:02 -0700 (PDT) In-Reply-To: <20180507180840.3486.67728.stgit@localhost.localdomain> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/07/2018 11:08 AM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch allows us to take care of unrolling the first segment and the > last segment of the loop for processing the segmented skb. Part of the > motivation for this is that it makes it easier to process the fact that the > first fame and all of the frames in between should be mostly identical > in terms of header data, and the last frame has differences in the length > and partial checksum. > > In addition I am dropping the header length calculation since we don't > really need it for anything but the last frame and it can be easily > obtained by just pulling the data_len and offset of tail from the transport > header. > > Signed-off-by: Alexander Duyck Reviewed-by: Eric Dumazet