From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me,
razor@blackwall.org, dw@davidwei.uk
Subject: Re: [PATCH net-next] net: only give queue leasing devices a separate instance lock class
Date: Thu, 1 Oct 2026 12:43:24 +0200 [thread overview]
Message-ID: <ef3b5996-db58-49ef-bdc6-30ee5a87e76b@redhat.com> (raw)
In-Reply-To: <20260929191543.3295633-1-kuba@kernel.org>
On 9/29/26 21:15, Jakub Kicinski wrote:
> diff --git a/net/core/netdev_queues.c b/net/core/netdev_queues.c
> index f5558b12877c..27cb6397bdd4 100644
> --- a/net/core/netdev_queues.c
> +++ b/net/core/netdev_queues.c
> @@ -61,21 +61,24 @@ struct device *netdev_queue_get_dma_dev(struct net_device *dev,
> bool netdev_can_create_queue(const struct net_device *dev,
> struct netlink_ext_ack *extack)
> {
> - if (dev->dev.parent) {
> - NL_SET_ERR_MSG(extack, "Device is not a virtual device");
> - return false;
> - }
> - if (!dev->queue_mgmt_ops ||
> - !dev->queue_mgmt_ops->ndo_queue_create) {
> - NL_SET_ERR_MSG(extack, "Device does not support queue creation");
> - return false;
> - }
> + const char *msg = NULL;
> +
> if (dev->real_num_rx_queues < 1 ||
Clashiko flags a possible data race while reading `real_num_rx_queues`
but that should be IMHO addressed separately, if ever addressed.
/P
next prev parent reply other threads:[~2026-10-01 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 19:15 [PATCH net-next] net: only give queue leasing devices a separate instance lock class Jakub Kicinski
2026-09-29 23:56 ` Stanislav Fomichev
2026-09-30 8:14 ` Nikolay Aleksandrov
2026-09-30 11:42 ` Daniel Borkmann
2026-10-01 10:43 ` Paolo Abeni [this message]
2026-10-01 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef3b5996-db58-49ef-bdc6-30ee5a87e76b@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox