From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B64C43381 for ; Fri, 15 Feb 2019 01:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C466A21B1C for ; Fri, 15 Feb 2019 01:30:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NaUuCAZr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730796AbfBOBac (ORCPT ); Thu, 14 Feb 2019 20:30:32 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:41106 "EHLO mail-pl1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728905AbfBOBac (ORCPT ); Thu, 14 Feb 2019 20:30:32 -0500 Received: by mail-pl1-f178.google.com with SMTP id k15so4096641pls.8 for ; Thu, 14 Feb 2019 17:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kF+G0wZjlaPlnTDp/8qT65QL1h+jEkbFyUdUcLHWLlk=; b=NaUuCAZrkzvR7VFf1CFuJMHRs2zf5jJPLgbz1I/3VLWylUDCBMRsJbUIjmrPJugr80 v9G/bkirBVsY74QJPMv75lGY8ZMKa6/2M6yzNyIOC8nQZgpK5Q+UjBe3zTyz3qAj2EOi YazvctYwtCDrtA2G1qqG+PlPtZEdsBaTF+mx+88sm3yNsNA35OX2/SmE+m+fh6EARxxi 9fQZVERhu4FLzeekVsBRaMNWdaR+E5BH5PWkqBpVb4pfCBw1/6AeGbrbwkRzhhuM0pZJ b7jkvXld5/4Pj788dQx167zUcsm0vxPNGCWgfEIAzK3MvL3ZAZUN0frCKQOxj/pldR9i 5YIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kF+G0wZjlaPlnTDp/8qT65QL1h+jEkbFyUdUcLHWLlk=; b=KHYYx+igWGSI7/93CdJ7ROaDj/JrNcYrITI69Pkzu5WA9xZzvHJMWoeyD+sPBqwyhA +/KqEb9pCXutGgrq+EsPVHHYiaUwVLgn5+fLG8b26vGR7G4AZMQxiLWN7l4+aPKLqY/K XOw2kS6tm9Mc8KEPoSq5TPKEHS3XCe6iPsk+eLFpmfEp6lmRLV8unSIi/VEnPYq7esTi w7+rlL0gM5H/91l/DuZ29UWygbmnE8ojM3Eeggz3TX37VHm847S0/VUpH/NTuIRY4evA d132ty/qsQQ/iB8erK0HT64kkI7sVEagR2VWiNZvCy+KSwzQ4inasRwMskdBOckZNxNC /Afg== X-Gm-Message-State: AHQUAubMTPNZLbg0vxL3ijgkVLGjogL3rbHMVmJMfkYthRYSWkrkfpd0 fQSPnQUvTeyJp1Y0JnGTy1s= X-Google-Smtp-Source: AHgI3IbJ5HW/HfLoAQgY2qrhtTAabqJ6ceDcnCLaW+mSf46twPMYupv9x4+mZTzofS5oayqPxU5bPA== X-Received: by 2002:a17:902:988b:: with SMTP id s11mr7401419plp.162.1550194231509; Thu, 14 Feb 2019 17:30:31 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id c4sm3637277pgq.85.2019.02.14.17.30.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 17:30:30 -0800 (PST) Subject: Re: (2) [Bug reporting] kernel panic during handle the dst unreach icmp msg. From: Eric Dumazet To: soukjin.bae@samsung.com, "netdev@vger.kernel.org" Cc: =?UTF-8?B?67CV7KKF7Ja4?= , Yuchung Cheng References: <20190214074641epcms1p1db1c5589f96718a440a166328eec9ebd@epcms1p1> <20190214235427epcms1p25712530506811b6279ffbe6c54914e72@epcms1p2> <4989ee5d-0de3-b7a7-494d-f0c133dfc465@gmail.com> Message-ID: Date: Thu, 14 Feb 2019 17:30:29 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4989ee5d-0de3-b7a7-494d-f0c133dfc465@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/14/2019 05:08 PM, Eric Dumazet wrote: > > > On 02/14/2019 03:54 PM, 배석진 wrote: >>> I do not believe this patch is needed. >>> >>> You probably hit another more serious bug, but since you do not post the full stack trace >>> it is hard to help. >>> >>> Are you using vti tunnel ? >> >> there's no working logs of vpn/vti/tun on platform or kernel history. >> and callstack has no functions about that. >> it looks like simple ipv4 usage. >> >> attaching full dump info. >> no additional bug or warning on entire kernel history. >> anything about tun or kasan even onther. >> >> thanks. >> >> >> <4>[60392.948306] I[1: ksoftirqd/1: 19] ------------[ cut here ]------------ >> <0>[60392.948334] I[1: ksoftirqd/1: 19] kernel BUG at net/ipv4/tcp_ipv4.c:519! > > What the code looks like at line 519 of net/ipv4/tcp_ipv4.c ? > > This is not a pristine kernel, anything could be wrong, you might have missed some critical backports. The current code checks if icsk->icsk_backoff is not zero, so it looks like we have to move some code like this. It looks a silly bug to have no packet in write/rtx queues, and a non zero icsk_backoff. diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 2079145a3b7c5f498af429c9a8289342e4421fca..cf3c5095c10e8e7e56621beae2f93c93de184489 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2528,6 +2528,7 @@ void tcp_write_queue_purge(struct sock *sk) sk_mem_reclaim(sk); tcp_clear_all_retrans_hints(tcp_sk(sk)); tcp_sk(sk)->packets_out = 0; + inet_csk(sk)->icsk_backoff = 0; } int tcp_disconnect(struct sock *sk, int flags) @@ -2576,7 +2577,6 @@ int tcp_disconnect(struct sock *sk, int flags) tp->write_seq += tp->max_window + 2; if (tp->write_seq == 0) tp->write_seq = 1; - icsk->icsk_backoff = 0; tp->snd_cwnd = 2; icsk->icsk_probes_out = 0; tp->snd_ssthresh = TCP_INFINITE_SSTHRESH;