From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB721217F27; Tue, 28 Apr 2026 13:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777383544; cv=none; b=kf1uXA4qHgAozAO6aCLVN3V08Z+6vupqLN718rl1xtLvAE6Okhcx2l05cauXrkpPxjssQ0Nvm9l/1XkMCLq5Vv0FcVh4jJ0veSGsyMpQaDXBgio6GoGCX/Lc+MLwx/TxvUOX2y1V8hGUrL6qMgRINJu7mr+kdMSIgC8svfD4NHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777383544; c=relaxed/simple; bh=rFPwSZS20EM5Gtg9/0HCSNe43DDm4D5C4hyaYLyb9aE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AgnmFqEnMLikbBhqKwXkVzZEBsQbhhrnVd58fVY4DanXN/Gv69nAC7HpoRX5uCALoIlfJwHsJW9KFWaQFGg7q+K5reH5wRMqTzeSRcTZGOiaWlasFqc3QTVG2g0cF4p++OHFRygv2OfyCCkc0WNAOoGdMHPxz2igextxXRWe03g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=ARlIW5Uv; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ARlIW5Uv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=PmJVtR5X4I8K/CxBoVDUflVQyelM2k7k4fazHOZAGKg=; b=ARlIW5Uvi/GVduQbItZQGvbgxT Pkod3sORgzLrSeGrKwhCA8jSk5TfiZGTRYnbGMbMP/7CzubcRifFve3Gnbgi2Y+YOaD0y38JFrrjS UIXN6dgWfPReyLDevG1K5hGFFjb/ubYUUKpNDNX6f+sE8EPcX1wX8ccYxFezXjiWqmNE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wHieJ-000LE6-Sn; Tue, 28 Apr 2026 15:38:51 +0200 Date: Tue, 28 Apr 2026 15:38:51 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: Jakub Kicinski , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Simon Horman , Russell King , Heiner Kallweit , Vladimir Oltean , Camelia Groza , thomas.petazzoni@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising Message-ID: References: <20260428125827.238469-1-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260428125827.238469-1-maxime.chevallier@bootlin.com> On Tue, Apr 28, 2026 at 02:58:27PM +0200, Maxime Chevallier wrote: > When configuring the link parameters in forced mode for the AQR-105, the > Extended Next Page bit gets advertised for Multi-Gigabit modes. > > This is done through bit 12 of MDIO_AN_ADVERTISE in MDIO_MMD_AN. This > contains a copy of the MII_ADVERTISE, for which 802.3 defines bit 12 as > the Extended Next Page advertising. This bit used to be marked as > reserved, but a proper define for it was added in : > > commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page") > > Let's use it instead of the ADVERTISE_RESV definition, making the code > more self-documenting. > > Signed-off-by: Maxime Chevallier Reviewed-by: Andrew Lunn Andrew