From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER Date: Mon, 30 Jul 2018 15:39:13 -0700 Message-ID: References: <20180717153645.7500-1-f.fainelli@gmail.com> <20180717153645.7500-2-f.fainelli@gmail.com> <47f52797-1540-5eeb-5ea8-3c0984fdfb11@gmail.com> <20180730223045.GB10559@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linville@tuxdriver.com, davem@davemloft.net, vivien.didelot@savoirfairelinux.com To: Andrew Lunn Return-path: Received: from mail-wr1-f65.google.com ([209.85.221.65]:42868 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726966AbeGaAQb (ORCPT ); Mon, 30 Jul 2018 20:16:31 -0400 Received: by mail-wr1-f65.google.com with SMTP id e7-v6so14509931wrs.9 for ; Mon, 30 Jul 2018 15:39:22 -0700 (PDT) In-Reply-To: <20180730223045.GB10559@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/30/2018 03:30 PM, Andrew Lunn wrote: >> One usability issue with this approach is that one cannot specify >> wake-on-LAN using WAKE_MAGICSECURE *and* WAKE_FILTER at the same time, >> since it uses the same location in the ioctl() structure that is being >> passed. Do you see this as a problem? > > Hi Florian > > Maybe you can think ahead to when ethtool gets a netlink > implementation, and you have more flexibility to pass both as > attributes? How does this affect the in kernel API? The thing is that I need this now, but when Michal's work on ethtool being migrated to netlink settles, we should have have any issues adding a proper storage area for specifying filters anymore. The issue here is of course that the size and layout of ethtool_wolinfo is largely fixed and set in stone, and therefore inflexible. -- Florian