From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBC6C433EF for ; Mon, 4 Jul 2022 09:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbiGDJMQ (ORCPT ); Mon, 4 Jul 2022 05:12:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232979AbiGDJMO (ORCPT ); Mon, 4 Jul 2022 05:12:14 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DA4DA1B4 for ; Mon, 4 Jul 2022 02:12:13 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id f39so14715383lfv.3 for ; Mon, 04 Jul 2022 02:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sMtVrpezShBuwcHrneDKoHxgcFVzeJwm+MAWXmI0nU0=; b=mNZIydifEE1JBpfDgkjlLPbKlyOUQeRSUqQa6CQLT9OF8XkeW/ZJ4oYcDIqK/5MlYf r1XNVgLhiovGfrpwGprmRTWiisNvOjAzP2kq33ajN18dz3zZhNKo7ISuB7HaRTi3Ygrp iw7+oZdHsM4ZrtCpzwPmZ0xJQKlOrVOBatiOWp21Mh7CjiPesSfSaxx9GU1txYSPDfxi hXpREtW03SMrXzu5ba0AdD9f9e86mFDiv9XsPpSV5Zq9hW6VnO57um+FTB+THdSWBKHv cyhlUics8AQB6hAa8fIltFEQVJjsTJR76zKCC8woVm6EG/V87ORn1IVp74H9olw33EjD GLSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sMtVrpezShBuwcHrneDKoHxgcFVzeJwm+MAWXmI0nU0=; b=VE9VCNWvvwd/nnWqz+GiCuxp+/YSDg9qpP4rAnhlEo8FV1gxREAIA8BNRRx5Ye7f2S vvvnJld2zxB9BHLkrMg0y0AR+AXX8QrSgrGpMxJu0X4SPQmC9ED+KFV3OQ8Ngy7gMo7H tkPJhwjAAR7SsuiHBqI/1R+26QFfCVF21OLnLxCc1KAjguuq8EZ727xfckExGgtlosDR zP27DscLpufxTv9WWlE4lWqm7vUndt8mf8Ybt+eRqohal4RZlu6zL4scoxcs+8rNyHG9 4UrRFdjQCfcwUTVM1Q/Nxad6TibILfij53KwfZ/KJ3XtJGtWNGvFJ/WNnv3OPaiN3bOe 0/wg== X-Gm-Message-State: AJIora8xkCDEtPxfDLqmGhGrxm/R+ybvRU98ulsWb6qmKgiKUGPD2NKk E2PLyB5naZ1MOI/P58v4tUlbEA== X-Google-Smtp-Source: AGRyM1vDjFRe/KRpPzDWJe4ostTBzue/9izXe/wL6YMqW/loMLucg9g2bltguu+0oMfcBHrPwHwzWw== X-Received: by 2002:a05:6512:2254:b0:481:4eab:7e39 with SMTP id i20-20020a056512225400b004814eab7e39mr13673738lfu.468.1656925931437; Mon, 04 Jul 2022 02:12:11 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id y9-20020a196409000000b00481541fb42asm2077966lfb.308.2022.07.04.02.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 02:12:10 -0700 (PDT) Message-ID: Date: Mon, 4 Jul 2022 11:12:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/3] dt-bings: net: fsl,fec: update compatible item Content-Language: en-US To: Wei Fang , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, peng.fan@nxp.com, ping.bai@nxp.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com References: <20220704101056.24821-1-wei.fang@nxp.com> <20220704101056.24821-2-wei.fang@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220704101056.24821-2-wei.fang@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04/07/2022 12:10, Wei Fang wrote: > Add compatible item for i.MX8ULP platform. Wrong subject prefix (dt-bindings). Wrong subject contents - do not use some generic sentences like "update X", just write what you are doing or what you want to achieve. For example: dt-bindings: net: fsl,fec: add i.MX8 ULP FEC > > Signed-off-by: Wei Fang > --- > Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml > index daa2f79a294f..6642c246951b 100644 > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml > @@ -40,6 +40,10 @@ properties: > - enum: > - fsl,imx7d-fec > - const: fsl,imx6sx-fec > + - items: > + - enum: > + - fsl,imx8ulp-fec > + - const: fsl,imx6ul-fec This is wrong. fsl,imx6ul-fec has to be followed by fsl,imx6q-fec. I think someone made similar mistakes earlier so this is a mess. > - items: > - const: fsl,imx8mq-fec > - const: fsl,imx6sx-fec Best regards, Krzysztof