From: Jens Axboe <axboe@kernel.dk>
To: Stefan Roesch <shr@devkernel.io>, kernel-team@fb.com
Cc: olivier@trillion01.com, netdev@vger.kernel.org,
io-uring@vger.kernel.org, kuba@kernel.org
Subject: Re: [RFC PATCH v3 2/3] io_uring: add api to set napi busy poll timeout.
Date: Wed, 16 Nov 2022 12:05:36 -0700 [thread overview]
Message-ID: <efa34cc0-b458-ea84-c23a-1ea8f46603be@kernel.dk> (raw)
In-Reply-To: <20221115070900.1788837-3-shr@devkernel.io>
On 11/15/22 12:08 AM, Stefan Roesch wrote:
> This adds an api to register the busy poll timeout from liburing. To be
> able to use this functionality, the corresponding liburing patch is needed.
Kind of related to the previous question, but I think we should just add
a single REGISTER opcode for this, and define a struct with the delay
setting. Add necessary padding for that, check padding for non-zero and
EINVAL if set. Then patch 3 can just add that struct field.
The IORING_REGISTER_NAPI can then also return the current settings by
just copying it back. That makes it a get/set API as well.
Patch 1 would be unaffected, this just changes patch 2+3 for the
io_uring API.
--
Jens Axboe
next prev parent reply other threads:[~2022-11-16 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 7:08 [RFC PATCH v3 0/3] io_uring: add napi busy polling support Stefan Roesch
2022-11-15 7:08 ` [RFC PATCH v3 1/3] " Stefan Roesch
2022-11-15 7:08 ` [RFC PATCH v3 2/3] io_uring: add api to set napi busy poll timeout Stefan Roesch
2022-11-16 19:05 ` Jens Axboe [this message]
2022-11-15 7:09 ` [RFC PATCH v3 3/3] io_uring: add api to set napi prefer busy poll Stefan Roesch
2022-11-16 18:31 ` [RFC PATCH v3 0/3] io_uring: add napi busy polling support Jakub Kicinski
2022-11-16 18:44 ` Jens Axboe
2022-11-16 20:09 ` Jakub Kicinski
2022-11-16 20:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efa34cc0-b458-ea84-c23a-1ea8f46603be@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier@trillion01.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).