From: Nikolay Aleksandrov <razor@blackwall.org>
To: Fabian Pfitzner <f.pfitzner@pengutronix.de>, netdev@vger.kernel.org
Cc: dsahern@gmail.com, idosch@nvidia.com,
bridge@lists.linux-foundation.org, entwicklung@pengutronix.de
Subject: Re: [PATCH iproute2-next v5 3/3] bridge: refactor bridge mcast querier function
Date: Tue, 24 Jun 2025 15:41:48 +0300 [thread overview]
Message-ID: <efd218b8-df7d-4d22-a22d-8c8a59c171b0@blackwall.org> (raw)
In-Reply-To: <20250623093316.1215970-4-f.pfitzner@pengutronix.de>
On 6/23/25 12:33, Fabian Pfitzner wrote:
> Make code more readable and consistent with other functions.
>
> Signed-off-by: Fabian Pfitzner <f.pfitzner@pengutronix.de>
> ---
> lib/bridge.c | 72 +++++++++++++++++++++++++---------------------------
> 1 file changed, 34 insertions(+), 38 deletions(-)
>
+1 for Ido's suggestion to remove the blank line, checkpatch isn't always
right :) but it's a minor nit, looks good to me overall:
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
prev parent reply other threads:[~2025-06-24 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 9:33 [PATCH iproute2-next v5 0/3] bridge: dump mcast querier state per vlan Fabian Pfitzner
2025-06-23 9:33 ` [PATCH iproute2-next v5 1/3] bridge: move mcast querier dumping code into a shared function Fabian Pfitzner
2025-06-24 11:55 ` Ido Schimmel
2025-06-24 12:40 ` Nikolay Aleksandrov
2025-06-23 9:33 ` [PATCH iproute2-next v5 2/3] bridge: dump mcast querier per vlan Fabian Pfitzner
2025-06-24 11:57 ` Ido Schimmel
2025-06-24 12:40 ` Nikolay Aleksandrov
2025-06-23 9:33 ` [PATCH iproute2-next v5 3/3] bridge: refactor bridge mcast querier function Fabian Pfitzner
2025-06-24 12:01 ` Ido Schimmel
2025-06-24 12:41 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd218b8-df7d-4d22-a22d-8c8a59c171b0@blackwall.org \
--to=razor@blackwall.org \
--cc=bridge@lists.linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=entwicklung@pengutronix.de \
--cc=f.pfitzner@pengutronix.de \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).