From: Paolo Abeni <pabeni@redhat.com>
To: Furong Xu <0x1207@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Joao Pinto <jpinto@synopsys.com>, Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com
Subject: Re: [PATCH net v2] net: stmmac: xgmac: fix handling of DPP safety error for DMA channels
Date: Tue, 30 Jan 2024 12:40:59 +0100 [thread overview]
Message-ID: <efd5126fcfe840d9bb7d583c8c69a3c97cdb2285.camel@redhat.com> (raw)
In-Reply-To: <20240126073928.1070729-1-0x1207@gmail.com>
On Fri, 2024-01-26 at 15:39 +0800, Furong Xu wrote:
> @@ -914,7 +964,12 @@ static int dwxgmac3_safety_feat_irq_status(struct net_device *ndev,
> ret |= !corr;
> }
>
> - err = dma & (XGMAC_DEUIS | XGMAC_DECIS);
> + /* DMA_DPP_Interrupt_Status is indicated by MCSIS bit in
> + * DMA_Safety_Interrupt_Status, so we handle DMA Data Path
> + * Parity Errors here
> + */
> + err = (dma & (XGMAC_DEUIS | XGMAC_DECIS)) ||
> + (dma & XGMAC_MCSIS);
The above syntax is IMHO confusing,
err = (dma & (XGMAC_DEUIS | XGMAC_DECIS | XGMAC_MCSIS))
should be more readable.
Cheers,
Paolo
prev parent reply other threads:[~2024-01-30 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 7:39 [PATCH net v2] net: stmmac: xgmac: fix handling of DPP safety error for DMA channels Furong Xu
2024-01-30 11:40 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd5126fcfe840d9bb7d583c8c69a3c97cdb2285.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=jpinto@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rock.xu@nio.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).