From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v4 08/18] net: davinci_emac: potentially get the MAC address from MTD Date: Fri, 20 Jul 2018 10:34:17 +0530 Message-ID: References: <20180629094039.7543-1-brgl@bgdev.pl> <20180629094039.7543-9-brgl@bgdev.pl> <03b77e24-9ab9-fa01-2387-9de0408a9942@gmail.com> <20180704070919.GA14051@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Linux ARM , Rob Herring , Florian Fainelli , David Lechner , Ivan Khoronzhuk , Kevin Hilman , Greg Kroah-Hartman , Jonathan Corbet , Russell King , Linux Kernel Mailing List , Bartosz Golaszewski , Grygorii Strashko , Ladislav Michl , netdev@vger.kernel.org, Lukas Wunner , linux-omap@vger.kernel.org, "David S . Miller" , Dan Carpenter To: Srinivas Kandagatla , Bartosz Golaszewski , Andrew Lunn Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On Monday 16 July 2018 02:26 PM, Srinivas Kandagatla wrote: > > > On 16/07/18 09:50, Sekhar Nori wrote: >> On Friday 13 July 2018 11:30 PM, Bartosz Golaszewski wrote: >> >>> We're getting close to rc5 so I'd like to make a case for this series >>> again. >>> >>> I understand that there's more to do than just the changes introduced >>> here, but we shouldn't try to fix several problems in many different >>> places at once. There's just too many moving pieces. I'd rather start >>> merging small improvements right away. >>> >>> The idea behind this series is to remove (almost) all users of >>> at24_platform_data. The davinci_emac patches are there only because we >>> need to remove some MAC adress reading stuff from the board files. >>> Having this code there and calling it back from EEPROM/MTD drivers is >>> already wrong and we should work towards using nvmem for that anyway. >>> >>> Currently for MTD the nvmem support series seems to be dead and it's >>> going to take some time before anything gets upstream. >>> >>> So I'd like to again ask you to consider picking up the patches from >>> this series to your respective trees or at the very least: I'd like to >>> ask Srinivas to pick up the nvmem patches and Sekhar to take the >>> first, non-controversial batch of davinci platform changes so that >>> we'll have less code to carry for the next release. >> >> I think those are patches 3-7. I can take those if I get an immutable >> commit over v4.18-rc1 from Srinivas with patches 1 & 2 applied. > nvmem patches go via Greg KH char-misc tree, if it makes things easy I > can provide Ack on nvmem patches, so that you can take these patches via > your tree? There is a lot of follow-up traffic on how exactly to develop the needed interfaces for reading mac address in mtd and/or network subsystem. But, I don't think any of that negates the need for nvmem lookups that work for non-device-tree and populating the lookups in mach-davinci board code. I am going to send patches 1-7 to ARM-SoC soon, so please do say if there is any disagreement on this. Thanks, Sekhar > > Let me know. > > --srini >> >> Thanks, >> Sekhar >>