From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: wenxu <wenxu@ucloud.cn>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Buslov <vladbu@nvidia.com>
Subject: Re: [PATCH v4 net-next 3/3] net/sched: sch_frag: add generic packet fragment support.
Date: Thu, 26 Nov 2020 08:26:37 -0500 [thread overview]
Message-ID: <efda6acc-0e9c-7686-40ca-4d906e585e0b@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpWO=vvw_iK9KaQAzEULXzUmmQWxs8xzNsXhTj3i4WcnbQ@mail.gmail.com>
On 2020-11-26 12:03 a.m., Cong Wang wrote:
> On Wed, Nov 25, 2020 at 11:11 AM Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Wed, 25 Nov 2020 12:01:23 +0800 wenxu@ucloud.cn wrote:
>>> From: wenxu <wenxu@ucloud.cn>
>>>
>>> Currently kernel tc subsystem can do conntrack in cat_ct. But when several
>>> fragment packets go through the act_ct, function tcf_ct_handle_fragments
>>> will defrag the packets to a big one. But the last action will redirect
>>> mirred to a device which maybe lead the reassembly big packet over the mtu
>>> of target device.
>>>
>>> This patch add support for a xmit hook to mirred, that gets executed before
>>> xmiting the packet. Then, when act_ct gets loaded, it configs that hook.
>>> The frag xmit hook maybe reused by other modules.
>>>
>>> Signed-off-by: wenxu <wenxu@ucloud.cn>
>>
>> LGMT. Cong, Jamal still fine by you guys?
>
> Yes, I do not look much into detail, but overall it definitely looks good.
> This is targeting net-next, so it is fine to fix anything we miss later.
>
> Acked-by: Cong Wang <cong.wang@bytedance.com>
Same here.
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
next prev parent reply other threads:[~2020-11-26 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 4:01 [PATCH v4 net-next 0/3] net/sched: fix over mtu packet of defrag in wenxu
2020-11-25 4:01 ` [PATCH v4 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb wenxu
2020-11-25 4:01 ` [PATCH v4 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit wenxu
2020-11-25 4:01 ` [PATCH v4 net-next 3/3] net/sched: sch_frag: add generic packet fragment support wenxu
2020-11-25 19:11 ` Jakub Kicinski
2020-11-26 5:03 ` Cong Wang
2020-11-26 13:26 ` Jamal Hadi Salim [this message]
2020-11-27 22:37 ` Jakub Kicinski
2020-11-25 20:04 ` Marcelo Ricardo Leitner
2020-11-26 5:14 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efda6acc-0e9c-7686-40ca-4d906e585e0b@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vladbu@nvidia.com \
--cc=wenxu@ucloud.cn \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox