public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* netlabel build warning...
@ 2014-08-06 21:55 David Miller
  2014-08-06 23:23 ` Paul Moore
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-08-06 21:55 UTC (permalink / raw)
  To: paul; +Cc: netdev


Please add inline to the nop versions of these helpers, thanks:

include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’ defined but not used [-Wunused-function]
include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’ defined but not used [-Wunused-function]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: netlabel build warning...
  2014-08-06 21:55 netlabel build warning David Miller
@ 2014-08-06 23:23 ` Paul Moore
  2014-08-09 16:19   ` Olof Johansson
  0 siblings, 1 reply; 5+ messages in thread
From: Paul Moore @ 2014-08-06 23:23 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

On Wed, Aug 6, 2014 at 5:55 PM, David Miller <davem@davemloft.net> wrote:
>
> Please add inline to the nop versions of these helpers, thanks:
>
> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’ defined but not used [-Wunused-function]
> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’ defined but not used [-Wunused-function]

I posted a fix to the SELinux list yesterday (link below); in
retrospect, I should have CC'd netdev, my apologies.  As soon as -rc1
is released and linux-next opens for business I'll be pushing the
patch to the SELinux #next branch.

 * http://marc.info/?l=selinux&m=140726989229890&w=2

-- 
paul moore
www.paul-moore.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: netlabel build warning...
  2014-08-06 23:23 ` Paul Moore
@ 2014-08-09 16:19   ` Olof Johansson
  2014-08-09 16:23     ` Paul Moore
  2014-08-09 16:27     ` Paul Moore
  0 siblings, 2 replies; 5+ messages in thread
From: Olof Johansson @ 2014-08-09 16:19 UTC (permalink / raw)
  To: Paul Moore; +Cc: David Miller, Network Development

On Wed, Aug 6, 2014 at 4:23 PM, Paul Moore <paul@paul-moore.com> wrote:
> On Wed, Aug 6, 2014 at 5:55 PM, David Miller <davem@davemloft.net> wrote:
>>
>> Please add inline to the nop versions of these helpers, thanks:
>>
>> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’ defined but not used [-Wunused-function]
>> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’ defined but not used [-Wunused-function]
>
> I posted a fix to the SELinux list yesterday (link below); in
> retrospect, I should have CC'd netdev, my apologies.  As soon as -rc1
> is released and linux-next opens for business I'll be pushing the
> patch to the SELinux #next branch.
>
>  * http://marc.info/?l=selinux&m=140726989229890&w=2

Why hold it off for 3.18? It's small and trivial and removes a
warning, might as well go in sooner.


-Olof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: netlabel build warning...
  2014-08-09 16:19   ` Olof Johansson
@ 2014-08-09 16:23     ` Paul Moore
  2014-08-09 16:27     ` Paul Moore
  1 sibling, 0 replies; 5+ messages in thread
From: Paul Moore @ 2014-08-09 16:23 UTC (permalink / raw)
  To: Olof Johansson; +Cc: David Miller, Network Development

On August 9, 2014 12:19:02 PM EDT, Olof Johansson <olof@lixom.net> wrote:
>On Wed, Aug 6, 2014 at 4:23 PM, Paul Moore <paul@paul-moore.com> wrote:
>> On Wed, Aug 6, 2014 at 5:55 PM, David Miller <davem@davemloft.net>
>wrote:
>>>
>>> Please add inline to the nop versions of these helpers, thanks:
>>>
>>> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’
>defined but not used [-Wunused-function]
>>> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’
>defined but not used [-Wunused-function]
>>
>> I posted a fix to the SELinux list yesterday (link below); in
>> retrospect, I should have CC'd netdev, my apologies.  As soon as -rc1
>> is released and linux-next opens for business I'll be pushing the
>> patch to the SELinux #next branch.
>>
>>  * http://marc.info/?l=selinux&m=140726989229890&w=2
>
>Why hold it off for 3.18? It's small and trivial and removes a
>warning, might as well go in sooner.
>
>
>-Olof

I sent a pull request to Linus yesterday and CC'd netdev.
-- 
paul moore
www.paul-moore.com 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: netlabel build warning...
  2014-08-09 16:19   ` Olof Johansson
  2014-08-09 16:23     ` Paul Moore
@ 2014-08-09 16:27     ` Paul Moore
  1 sibling, 0 replies; 5+ messages in thread
From: Paul Moore @ 2014-08-09 16:27 UTC (permalink / raw)
  To: Olof Johansson; +Cc: David Miller, Network Development

On August 9, 2014 12:19:02 PM EDT, Olof Johansson <olof@lixom.net> wrote:
>On Wed, Aug 6, 2014 at 4:23 PM, Paul Moore <paul@paul-moore.com> wrote:
>> On Wed, Aug 6, 2014 at 5:55 PM, David Miller <davem@davemloft.net>
>wrote:
>>>
>>> Please add inline to the nop versions of these helpers, thanks:
>>>
>>> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’
>defined but not used [-Wunused-function]
>>> include/net/netlabel.h:527:12: warning: ‘netlbl_catmap_setlong’
>defined but not used [-Wunused-function]
>>
>> I posted a fix to the SELinux list yesterday (link below); in
>> retrospect, I should have CC'd netdev, my apologies.  As soon as -rc1
>> is released and linux-next opens for business I'll be pushing the
>> patch to the SELinux #next branch.
>>
>>  * http://marc.info/?l=selinux&m=140726989229890&w=2
>
>Why hold it off for 3.18? It's small and trivial and removes a
>warning, might as well go in sooner.
>
>
>-Olof

I sent a pull request to Linus yesterday and CC'd netdev.
-- 
paul moore
www.paul-moore.com 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-08-09 16:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-06 21:55 netlabel build warning David Miller
2014-08-06 23:23 ` Paul Moore
2014-08-09 16:19   ` Olof Johansson
2014-08-09 16:23     ` Paul Moore
2014-08-09 16:27     ` Paul Moore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox