From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>,
David Miller <davem@davemloft.net>
Cc: Magnus Damm <magnus.damm@gmail.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: sh_eth: rename name structures as rcar_gen[12]_*
Date: Tue, 17 Oct 2017 13:17:54 +0300 [thread overview]
Message-ID: <efe31736-9dda-ae2c-98c1-39073c64fdc7@cogentembedded.com> (raw)
In-Reply-To: <20171017074747.24159-3-horms+renesas@verge.net.au>
Hello!
On 10/17/2017 10:47 AM, Simon Horman wrote:
> Rename structures describing R-Car SoCs as rcar_gen[12]_*
> rather than r8a77[79]x_*. This seems a little easier on the
> eyes will make things slightly cleaner in a follow-up
^
"And" missing here?
> patch that adds fallback-compatibility strings for these SoCs.
>
> Note that R-Car Gen2 and RZ/G1 have many compatible IP blocks. The
> approach that has been consistently taken for other IP blocks is to name
> common code, compatibility strings and so on after Rcar Gen2.
R-Car.
> Also rename sh_eth_set_rate_r8a777x as sh_eth_set_rate_rcar as
> it it is used by the R-Car generations supported by the driver.
>
> This patch should have no run-time effect and
> is compile-tested only.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[...]
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
next prev parent reply other threads:[~2017-10-17 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 7:47 [PATCH net-next 0/3] net: sh_eth: add R-Car Gen[12] fallback compatibility strings Simon Horman
2017-10-17 7:47 ` [PATCH net-next 1/3] dt-bindings: " Simon Horman
2017-10-17 8:22 ` Geert Uytterhoeven
2017-10-17 10:14 ` Sergei Shtylyov
2017-10-17 10:18 ` Sergei Shtylyov
2017-10-17 7:47 ` [PATCH net-next 2/3] net: sh_eth: rename name structures as rcar_gen[12]_* Simon Horman
2017-10-17 8:20 ` Geert Uytterhoeven
2017-10-17 10:17 ` Sergei Shtylyov [this message]
2017-10-17 7:47 ` [PATCH net-next 3/3] net: sh_eth: implement R-Car Gen[12] fallback compatibility strings Simon Horman
2017-10-17 8:21 ` Geert Uytterhoeven
2017-10-17 10:20 ` Sergei Shtylyov
2017-10-18 6:49 ` [PATCH net-next 0/3] net: sh_eth: add " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efe31736-9dda-ae2c-98c1-39073c64fdc7@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox