From: Kui-Feng Lee <sinquersw@gmail.com>
To: David Ahern <dsahern@kernel.org>,
thinker.li@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,
martin.lau@linux.dev, kernel-team@meta.com, yhs@meta.com
Cc: kuifeng@meta.com
Subject: Re: [PATCH net-next v5 1/2] net/ipv6: Remove expired routes with a separated list of routes.
Date: Wed, 2 Aug 2023 21:19:22 -0700 [thread overview]
Message-ID: <efe86f7b-ae82-e3cd-f160-3d9ee0bfa05c@gmail.com> (raw)
In-Reply-To: <e8ca99dd-416a-f1a0-c858-1d8889a83592@kernel.org>
On 8/2/23 19:00, David Ahern wrote:
> On 8/1/23 6:43 PM, thinker.li@gmail.com wrote:
>> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
>> index bac768d36cc1..3059e439817a 100644
>> --- a/net/ipv6/ip6_fib.c
>> +++ b/net/ipv6/ip6_fib.c
>> @@ -1480,6 +1488,9 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,
>> list_add(&rt->nh_list, &rt->nh->f6i_list);
>> __fib6_update_sernum_upto_root(rt, fib6_new_sernum(info->nl_net));
>> fib6_start_gc(info->nl_net, rt);
>> +
>> + if (fib6_has_expires(rt))
>> + hlist_add_head(&rt->gc_link, &table->tb6_gc_hlist);
>
> This should go before the start_gc.
Agree
next prev parent reply other threads:[~2023-08-03 4:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 0:43 [PATCH net-next v5 0/2] Remove expired routes with a separated list of routes thinker.li
2023-08-02 0:43 ` [PATCH net-next v5 1/2] net/ipv6: " thinker.li
2023-08-03 2:00 ` David Ahern
2023-08-03 4:19 ` Kui-Feng Lee [this message]
2023-08-02 0:43 ` [PATCH net-next v5 2/2] selftests: fib_tests: Add a test case for IPv6 garbage collection thinker.li
2023-08-03 2:06 ` David Ahern
2023-08-03 4:09 ` Kui-Feng Lee
2023-08-03 19:49 ` David Ahern
2023-08-03 20:04 ` Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efe86f7b-ae82-e3cd-f160-3d9ee0bfa05c@gmail.com \
--to=sinquersw@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thinker.li@gmail.com \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).