From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: "Brett Creeley" <bcreeley@amd.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Igor Russkikh" <irusskikh@marvell.com>,
"Egor Pomozov" <epomozov@marvell.com>,
"Potnuri Bharat Teja" <bharat@chelsio.com>,
"Dimitris Michailidis" <dmichail@fungible.com>,
"Jian Shen" <shenjian15@huawei.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Jijie Shao" <shaojijie@huawei.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Geetha sowjanya" <gakula@marvell.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
"Bharat Bhushan" <bbhushan2@marvell.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Brett Creeley" <brett.creeley@amd.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Paul Barker" <paul@pbarker.dev>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"MD Danish Anwar" <danishanwar@ti.com>,
"Roger Quadros" <rogerq@kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net-next 10/14] ionic: convert to ndo_hwtstamp API
Date: Sat, 18 Oct 2025 14:51:54 +0100 [thread overview]
Message-ID: <eff0d886-ff55-4771-9c97-d7535081dfc0@linux.dev> (raw)
In-Reply-To: <6641d925-b953-46b3-9e45-2284d5e2e8ad@amd.com>
On 17/10/2025 18:11, Brett Creeley wrote:
>> ionic_netdev_ops = {
>> .ndo_get_vf_config = ionic_get_vf_config,
>> .ndo_set_vf_link_state = ionic_set_vf_link_state,
>> .ndo_get_vf_stats = ionic_get_vf_stats,
>> + .ndo_hwtstamp_get = ionic_lif_hwstamp_get,
>> + .ndo_hwtstamp_set = ionic_lif_hwstamp_set,
>
> Nit, but if you are changing this and you have to re-spin the series it
> would align with the other ndo callbacks to rename these by removing the
> "_lif_" portion of the name:
>
> ionic_hwstamp_get
> ionic_hwstamp_set
>
> Other than that LGTM.
>
> Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Thanks Brett, I took your suggestion before sending out v2.
next prev parent reply other threads:[~2025-10-18 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 16:37 [PATCH net-next 06/14] tsnep: convert to ndo_hwtstatmp API Vadim Fedorenko
2025-10-13 16:37 ` [PATCH net-next 07/14] funeth: convert to ndo_hwtstamp API Vadim Fedorenko
2025-10-13 16:37 ` [PATCH net-next 08/14] octeontx2: " Vadim Fedorenko
2025-10-13 16:37 ` [PATCH net-next 09/14] mlx4: " Vadim Fedorenko
2025-10-13 16:37 ` [PATCH net-next 10/14] ionic: " Vadim Fedorenko
2025-10-17 17:11 ` Brett Creeley
2025-10-18 13:51 ` Vadim Fedorenko [this message]
2025-10-13 16:37 ` [PATCH net-next 11/14] net: ravb: " Vadim Fedorenko
2025-10-13 16:37 ` [PATCH net-next 12/14] net: renesas: rswitch: " Vadim Fedorenko
2025-10-13 16:37 ` [PATCH net-next 13/14] net: hns3: add hwtstamp_get/hwtstamp_set ops Vadim Fedorenko
2025-10-14 11:26 ` Simon Horman
2025-10-14 11:33 ` Vadim Fedorenko
2025-10-17 20:59 ` [PATCH net-next 06/14] tsnep: convert to ndo_hwtstatmp API Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff0d886-ff55-4771-9c97-d7535081dfc0@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=bcreeley@amd.com \
--cc=bharat@chelsio.com \
--cc=brett.creeley@amd.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dmichail@fungible.com \
--cc=edumazet@google.com \
--cc=epomozov@marvell.com \
--cc=gakula@marvell.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul@pbarker.dev \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tariqt@nvidia.com \
--cc=vladimir.oltean@nxp.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).