From: "Arnd Bergmann" <arnd@kernel.org>
To: "Vladimir Oltean" <vladimir.oltean@nxp.com>
Cc: "Wei Fang" <wei.fang@nxp.com>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Clark Wang" <xiaoning.wang@nxp.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH net] net: enetc: fix the netc-lib driver build dependency
Date: Wed, 04 Jun 2025 11:30:58 +0200 [thread overview]
Message-ID: <effd3e84-8aa7-4c06-ae36-effbf3b4f87d@app.fastmail.com> (raw)
In-Reply-To: <20250604091111.oo2o2xd2zeqqisaf@skbuf>
On Wed, Jun 4, 2025, at 11:11, Vladimir Oltean wrote:
> On Wed, Jun 04, 2025 at 09:24:22AM +0200, Arnd Bergmann wrote:
>> On Wed, Jun 4, 2025, at 04:44, Wei Fang wrote:
> Thanks, this seems to be the best proposal thus far. IMO it is also easy
> to maintain and it also fully satisfies the imposed requirements. I checked
> that when FSL_ENETC_CORE goes to m, NXP_NETC_LIB also goes to m, and
> when it remains y, the latter also remains y. Note, FSL_ENETC_CORE only
> goes to m when all its selecters are m. More importantly, when
> NXP_ENETC4=n, NXP_NETC_LIB is also n. The drivers seem to build in all
> cases.
>
> Will you send a patch with this proposal, or should Wei do it with a
> Suggested-by?
I'd prefer Wei to send it as a tested patch with my Suggested-by.
I've also tested this version overnight on my randconfig build
system.
Arnd
next prev parent reply other threads:[~2025-06-04 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 10:50 [PATCH net] net: enetc: fix the netc-lib driver build dependency Wei Fang
2025-06-03 20:45 ` Vladimir Oltean
2025-06-04 2:44 ` Wei Fang
2025-06-04 7:24 ` Arnd Bergmann
2025-06-04 9:11 ` Vladimir Oltean
2025-06-04 9:30 ` Arnd Bergmann [this message]
2025-06-04 11:32 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=effd3e84-8aa7-4c06-ae36-effbf3b4f87d@app.fastmail.com \
--to=arnd@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox