From: subashab@codeaurora.org
To: Alex Elder <elder@linaro.org>
Cc: ap420073@gmail.com, davem@davemloft.net, netdev@vger.kernel.org,
Sean Tranchetti <stranche@codeaurora.org>
Subject: Re: [PATCH net] net: qualcomm: rmnet: Allow configuration updates to existing devices
Date: Wed, 01 Apr 2020 15:44:50 -0600 [thread overview]
Message-ID: <f010365522863594b59d16901aeecbfd@codeaurora.org> (raw)
In-Reply-To: <b17b2e15-515f-a758-b8bd-e34a62f405bf@linaro.org>
On 2020-03-31 18:06, Alex Elder wrote:
> On 3/31/20 5:43 PM, Subash Abhinov Kasiviswanathan wrote:
>> This allows the changelink operation to succeed if the mux_id was
>> specified as an argument. Note that the mux_id must match the
>> existing mux_id of the rmnet device or should be an unused mux_id.
>>
>> Fixes: 1dc49e9d164c ("net: rmnet: do not allow to change mux id if mux
>> id is duplicated")
>> Reported-by: Alex Elder <elder@linaro.org>
>> Signed-off-by: Sean Tranchetti <stranche@codeaurora.org>
>> Signed-off-by: Subash Abhinov Kasiviswanathan
>> <subashab@codeaurora.org>
>
> This was a regression in 5.6, and got back-ported to 5.5.11 and
> possibly further back. Please be sure the fix gets applied to
> stable branches if appropriate.
>
> If you happen to post a second version of this I have a suggestion,
> below. But the patch looks OK to me as-is.
>
> Thanks.
>
> Tested-by: Alex Elder <elder@linaro.org>
>
>> ---
>> .../ethernet/qualcomm/rmnet/rmnet_config.c | 21
>> ++++++++++++-------
>> 1 file changed, 13 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
>> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
>> index fbf4cbcf1a65..06332984399d 100644
>> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
>> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
>> @@ -294,19 +294,24 @@ static int rmnet_changelink(struct net_device
>> *dev, struct nlattr *tb[],
>>
>> if (data[IFLA_RMNET_MUX_ID]) {
>> mux_id = nla_get_u16(data[IFLA_RMNET_MUX_ID]);
>> - if (rmnet_get_endpoint(port, mux_id)) {
>> - NL_SET_ERR_MSG_MOD(extack, "MUX ID already exists");
>> - return -EINVAL;
>> - }
>
> My suggestion is this: Since the endpoint pointer isn't used
> outside the "if (mux_id != priv->mux_id)" block, you could
> do the lookup inside that block.
I've sent a v2 now based on your comment.
next prev parent reply other threads:[~2020-04-01 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 22:43 [PATCH net] net: qualcomm: rmnet: Allow configuration updates to existing devices Subash Abhinov Kasiviswanathan
2020-04-01 0:06 ` Alex Elder
2020-04-01 21:44 ` subashab [this message]
2020-04-02 13:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f010365522863594b59d16901aeecbfd@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=elder@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=stranche@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).