netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: maxime.deroucy@gmail.com
To: netdev@vger.kernel.org
Subject: [PATCH iproute2-next] ipaddress: remove 'label' compatibility with Linux-2.0 net aliases
Date: Thu, 03 Mar 2022 23:14:55 +0100	[thread overview]
Message-ID: <f0215a333fd80102cfab9c560fc2872e8eddb079.camel@gmail.com> (raw)

As Linux-2.0 is getting old and systemd allows non Linux-2.0 compatible
aliases to be set, I think iproute2 should be able to manage such
aliases.
---
 ip/ipaddress.c           | 16 ----------------
 man/man8/ip-address.8.in |  3 ---
 2 files changed, 19 deletions(-)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 739b0b9c..a80996ef 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -2349,16 +2349,6 @@ static bool ipaddr_is_multicast(inet_prefix *a)
                return false;
 }
 
-static bool is_valid_label(const char *dev, const char *label)
-{
-       size_t len = strlen(dev);
-
-       if (strncmp(label, dev, len) != 0)
-               return false;
-
-       return label[len] == '\0' || label[len] == ':';
-}
-
 static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
 {
        struct {
@@ -2501,12 +2491,6 @@ static int ipaddr_modify(int cmd, int flags, int
argc, char **argv)
                fprintf(stderr, "Not enough information: \"dev\"
argument is required.\n");
                return -1;
        }
-       if (l && !is_valid_label(d, l)) {
-               fprintf(stderr,
-                       "\"label\" (%s) must match \"dev\" (%s) or be
prefixed by \"dev\" with a colon.\n",
-                       l, d);
-               return -1;
-       }
 
        if (peer_len == 0 && local_len) {
                if (cmd == RTM_DELADDR && lcl.family == AF_INET &&
!(lcl.flags & PREFIXLEN_SPECIFIED)) {
diff --git a/man/man8/ip-address.8.in b/man/man8/ip-address.8.in
index a614ac64..1846252d 100644
--- a/man/man8/ip-address.8.in
+++ b/man/man8/ip-address.8.in
@@ -195,9 +195,6 @@ is derived by setting/resetting the host bits of
the interface prefix.
 .TP
 .BI label " LABEL"
 Each address may be tagged with a label string.
-In order to preserve compatibility with Linux-2.0 net aliases,
-this string must coincide with the name of the device or must be
prefixed
-with the device name followed by colon.
 The maximum allowed total length of label is 15 characters.
 
 .TP


             reply	other threads:[~2022-03-03 22:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 22:14 maxime.deroucy [this message]
2022-03-03 22:37 ` [PATCH iproute2-next] ipaddress: remove 'label' compatibility with Linux-2.0 net aliases Stephen Hemminger
2022-03-04 22:24 ` Stephen Hemminger
2022-03-07 11:23   ` [PATCH] " Maxime de Roucy
2022-03-07 11:32   ` [PATCH v2] " Maxime de Roucy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0215a333fd80102cfab9c560fc2872e8eddb079.camel@gmail.com \
    --to=maxime.deroucy@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).