From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: net: phy: consolidate PHY reset in phy_init_hw() Date: Wed, 13 Dec 2017 13:03:47 -0800 Message-ID: References: <20171213203512.GC932@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Florian Fainelli , "David S. Miller" , "netdev@vger.kernel.org" To: Andrew Lunn Return-path: Received: from alln-iport-2.cisco.com ([173.37.142.89]:64031 "EHLO alln-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbdLMVDh (ORCPT ); Wed, 13 Dec 2017 16:03:37 -0500 In-Reply-To: <20171213203512.GC932@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/13/2017 12:35 PM, Andrew Lunn wrote: > On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote: >> Hi, >> >> https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608 > Hi Daniel > > This is a 4 year old patch, so i'm kind of surprised nobody noticed > this before. How did you conclude this patch is the problem? > > Thanks > Andrew I just did some debugging to find the -ETIMEDOUT error message which I tracked back to the waiting routine inside this patch. I did do a high level bisect jumping between major versions, and the issue seemed to go away around the time when this patch was added. v3.10 didn't have it, and one of the version of the kernel immediately after had it, either v3.11 or v3.12 .. This phy may not be used often, that might be part of it. Daniel