From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C405F14A82; Thu, 11 Jan 2024 10:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SldAGIOZ" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-555e07761acso6192178a12.0; Thu, 11 Jan 2024 02:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704968649; x=1705573449; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=PjiY07DgS9NGEAkLzhjaqeWPDRIGprm9hhNvl6O95fI=; b=SldAGIOZAhHpS7Yb3KcbUR+ZG+qkWNCMJBnj3739D6benLwoKMBrC2kuEuZd+zQhgT McXfoR/aRGuGzef2tz8c9LgDY4cMsgNcrOWkodIWHbb/f+Ynelj1+y9I8LB/N89INVbi +xDUq2KVVavGOeg3eYJwDalrBM/OPS8/hcuhLKttq4k7I44QMAuJkLzRa4Wka0qQxZfp Cypb5nDPzFGpYCfkv8/wjbKMI1WsKoH8M4SMozsDyT/6bCDaTYWHv7GvKmENz5923YgQ wDCKgvobWP7Zpvr0tdr9fWozxEH9d+Wqc4hZnQFk4nGIzXbtNSgqB3cZP+g+kEWHY/E8 fcmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704968649; x=1705573449; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PjiY07DgS9NGEAkLzhjaqeWPDRIGprm9hhNvl6O95fI=; b=douQ9Germ2JhGexW7pqr0z1JiOZnkiVrwW8QF/MXbs3OTt/tiNlbLmK7Mdo1Psh+8F 1HekdN7nln2k7vKx2LrB/nKq7ZX+WktoYY69+3FD0K83P7YtOH8VOCVlGEINottzQTrw 7kbubmD58h49XbZbD9ZWTztb0SfCtEg/BasI/5Sab+XCcKzXKwrW0Ce29bmuSwwzxKaO nj9PkLOrfcTQ10Js5RR+eeaSowuIQny9f9a0zh0R5CsCQx5Eu7bf0PP33914aLYbbBnJ Jw2eNDu7zrcKZRcLn7/Y0OiCVLNxk2K4boezA9MFKdDehLK54sllvDH0nsrbjrCMizMu 8XyQ== X-Gm-Message-State: AOJu0Yy4SbEjX05NBtL+LA4fdOq6ZgTaYt670FU2sZqCL58kN0O116+P KzJNTASKtZv4Yap9HRATpbr7x2niaT4= X-Google-Smtp-Source: AGHT+IHpL15YWz+/ySbWPkUub6f25eF+aC9wqdEjR6dcWJ7B4UfAErj+2qLbqLfWqQWTJucmhi+dZQ== X-Received: by 2002:a17:906:b56:b0:a2a:c81:d80f with SMTP id v22-20020a1709060b5600b00a2a0c81d80fmr332489ejg.12.1704968648593; Thu, 11 Jan 2024 02:24:08 -0800 (PST) Received: from ?IPV6:2a01:c23:bc57:a800:4da8:42cb:4e37:553d? (dynamic-2a01-0c23-bc57-a800-4da8-42cb-4e37-553d.c23.pool.telefonica.de. [2a01:c23:bc57:a800:4da8:42cb:4e37:553d]) by smtp.googlemail.com with ESMTPSA id ce2-20020a170906b24200b00a26a0145c5esm394999ejb.116.2024.01.11.02.24.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 02:24:08 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 11:24:08 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESUBMIT] leds: trigger: netdev: add core support for hw not supporting fallback to LED sw control To: Lee Jones Cc: Pavel Machek , "linux-leds@vger.kernel.org" , "netdev@vger.kernel.org" , Andrew Lunn References: <3fd5184c-3641-4b0b-b59a-f489ec69a6cd@gmail.com> <7b6cf0fb-4c77-4088-b87b-5649cfaa697e@gmail.com> <20240111084425.GJ7948@google.com> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <20240111084425.GJ7948@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11.01.2024 09:44, Lee Jones wrote: > On Sun, 17 Dec 2023, Heiner Kallweit wrote: > >> On 17.12.2023 19:46, Heiner Kallweit wrote: >>> If hw doesn't support sw control of the LED and we switch to a mode >>> not supported by hw, currently we get lots of errors because neither >>> brigthness_set() nor brithness_set_blocking() is set. >>> Deal with this by not falling back to sw control, and return >>> -EOPNOTSUPP to the user. Note that we still store the new mode. >>> This is needed in case an intermediate unsupported mode is necessary >>> to switch from one supported mode to another. >>> >>> Add a comment explaining how a driver for such hw is supposed to behave. >>> >>> Signed-off-by: Heiner Kallweit >>> --- >> >> For whatever reason this patch (original version and resubmit) doesn't >> show up on linux-leds patchwork. In netdev patchwork it's visible. > > Never used it. Do you have a link? > This is the original patch in netdev patchwork https://patchwork.kernel.org/project/netdevbpf/patch/91e9f4c6-d869-45be-be72-ac49a3c3b818@gmail.com/ This is my patches in linux-leds patchwork. The one from Dec 6th is missing here. https://patches.linaro.org/project/linux-leds/list/?series=&submitter=6702&state=*&q=&archive=&delegate= However the resubmitted one showed up later.