From: Florian Fainelli <f.fainelli@gmail.com>
To: Phil Reid <preid@electromag.com.au>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
dongsheng.wang@hxt-semitech.com, cphealy@gmail.com,
clemens.gruber@pqgruber.com, hkallweit1@gmail.com, nbd@nbd.name,
harini.katakam@xilinx.com
Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset
Date: Fri, 15 Mar 2019 14:58:32 -0700 [thread overview]
Message-ID: <f0881e08-95d7-8f8e-125f-9aa37ed9ff2f@gmail.com> (raw)
In-Reply-To: <5ddf46b1-1959-832d-c6a5-86d8f93dc409@electromag.com.au>
On 3/15/19 1:52 AM, Phil Reid wrote:
> G'day All,
>
> I've just update from kernel 4.19 to 5.0 on a custom board that has a
> marvell
> dsa mv88e6085 and the phy on the mv88e6085 will only connect at 10Mb/s with
> the above mentioned patch applied.
>
> Bisecting the issue lead me to the following patch.
>
> d6ab93364734bd (net: phy: marvell: Avoid unnecessary soft reset)
>
> Revert the patch, and the associated build fix
> 4b1bd6976945417 (net: phy: marvell: Fix build.)
> restores connections to 1Gb/s.
>
> Anyone have any thoughts as to the correct fix?
What is the PHY OUI (MII_PHYSID1/ID2) for that PHY? We may need to add a
specific entry in drivers/net/phy/marvell.c to restore the software
reset to commit changes to the register.
--
Florian
next prev parent reply other threads:[~2019-03-15 21:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 18:28 [PATCH net-next 0/2] net: phy: Eliminate unnecessary soft Florian Fainelli
2018-09-25 18:28 ` [PATCH net-next 1/2] net: phy: Stop with excessive soft reset Florian Fainelli
2018-09-25 18:28 ` [PATCH net-next 2/2] net: phy: marvell: Avoid unnecessary " Florian Fainelli
2019-03-15 8:52 ` regression from: " Phil Reid
2019-03-15 21:58 ` Florian Fainelli [this message]
2019-03-18 2:11 ` Phil Reid
2019-03-18 17:09 ` Florian Fainelli
2019-03-18 17:15 ` Andrew Lunn
2019-03-18 17:18 ` Chris Healy
2019-03-18 17:53 ` Andrew Lunn
2019-03-19 1:32 ` Phil Reid
2019-03-19 16:53 ` Florian Fainelli
2019-03-20 1:33 ` Phil Reid
2019-03-20 2:34 ` liweihang
2019-03-20 3:37 ` Florian Fainelli
2019-03-20 5:16 ` Phil Reid
2019-03-20 6:39 ` Heiner Kallweit
2019-03-20 7:08 ` Phil Reid
2019-03-20 12:22 ` liweihang
2019-03-20 18:15 ` Heiner Kallweit
2019-03-20 20:35 ` Maxim Uvarov
2019-03-21 6:16 ` liweihang
2019-03-21 8:07 ` Phil Reid
2018-09-26 3:27 ` [PATCH net-next 0/2] net: phy: Eliminate unnecessary soft David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0881e08-95d7-8f8e-125f-9aa37ed9ff2f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=clemens.gruber@pqgruber.com \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=dongsheng.wang@hxt-semitech.com \
--cc=harini.katakam@xilinx.com \
--cc=hkallweit1@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).