From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH v2] wireless: mark expected switch fall-throughs Date: Tue, 23 Oct 2018 10:59:23 +0200 Message-ID: References: <20181023001308.GA4150@embeddedor.com> <0b3197a734f71bdfffaf717e63b17e2fe31720a2.camel@sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook To: Johannes Berg , "David S. Miller" Return-path: Received: from gateway30.websitewelcome.com ([192.185.149.4]:11851 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727999AbeJWRWH (ORCPT ); Tue, 23 Oct 2018 13:22:07 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id CCD10C311 for ; Tue, 23 Oct 2018 03:59:38 -0500 (CDT) In-Reply-To: <0b3197a734f71bdfffaf717e63b17e2fe31720a2.camel@sipsolutions.net> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 10/23/18 9:01 AM, Johannes Berg wrote: > On Tue, 2018-10-23 at 02:13 +0200, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This code was not tested and GCC 7.2.0 was used to compile it. > > Look, I'm not going to make this any clearer: I'm not applying patches > like that where you've invested no effort whatsoever on verifying that > they're correct. > How do you suggest me to verify that every part is correct in this type of patches? Thanks