From: Michael Gur <michaelgur@nvidia.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Edward Srouji <edwards@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH rdma-next v2 02/11] IB/core: Introduce FRMR pools
Date: Tue, 27 Jan 2026 00:55:04 +0200 [thread overview]
Message-ID: <f0b1bc8f-8b3b-4e4a-9043-3b80ede3ac12@nvidia.com> (raw)
In-Reply-To: <20260120164438.GR961572@ziepe.ca>
On 1/20/2026 6:44 PM, Jason Gunthorpe wrote:
> On Mon, Dec 22, 2025 at 02:40:37PM +0200, Edward Srouji wrote:
>> +static int compare_keys(struct ib_frmr_key *key1, struct ib_frmr_key *key2)
>> +{
>>
> This stuff should be using cmp_int().
>
>> +static struct ib_frmr_pool *ib_frmr_pool_find(struct ib_frmr_pools *pools,
>> + struct ib_frmr_key *key)
>> +{
>>
>> Use the rb_find() helper
>>
>> +static struct ib_frmr_pool *create_frmr_pool(struct ib_device *device,
>> + struct ib_frmr_key *key)
>> +{
>>
> I think this is rb_find_add() ?
Ack, thanks.
Moved all comparisons except dma_blocks to use cmp_int().
Moved the 'find' and 'create' paths to use the rb tree helpers.
While at it, changed compare_keys() to be inline.
Will send these with V3.
Michael
next prev parent reply other threads:[~2026-01-26 22:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 12:40 [PATCH rdma-next v2 00/11] RDMA/core: Introduce FRMR pools infrastructure Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 01/11] RDMA/mlx5: Move device async_ctx initialization Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 02/11] IB/core: Introduce FRMR pools Edward Srouji
2026-01-20 16:44 ` Jason Gunthorpe
2026-01-26 22:55 ` Michael Gur [this message]
2025-12-22 12:40 ` [PATCH rdma-next v2 03/11] RDMA/core: Add aging to " Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 04/11] RDMA/core: Add FRMR pools statistics Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 05/11] RDMA/core: Add pinned handles to FRMR pools Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 06/11] RDMA/mlx5: Switch from MR cache " Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 07/11] net/mlx5: Drop MR cache related code Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 08/11] RDMA/nldev: Add command to get FRMR pools Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 09/11] RDMA/core: Add netlink command to modify FRMR aging Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 10/11] RDMA/nldev: Add command to set pinned FRMR handles Edward Srouji
2025-12-22 12:40 ` [PATCH rdma-next v2 11/11] RDMA/nldev: Expose kernel-internal FRMR pools in netlink Edward Srouji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b1bc8f-8b3b-4e4a-9043-3b80ede3ac12@nvidia.com \
--to=michaelgur@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=edwards@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox