From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DA5C169C4 for ; Wed, 6 Feb 2019 09:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E296920844 for ; Wed, 6 Feb 2019 09:42:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="LLcBPUGa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728947AbfBFJma (ORCPT ); Wed, 6 Feb 2019 04:42:30 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38012 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726900AbfBFJma (ORCPT ); Wed, 6 Feb 2019 04:42:30 -0500 Received: by mail-wr1-f66.google.com with SMTP id v13so6749050wrw.5 for ; Wed, 06 Feb 2019 01:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=P0ZfSMYTTnjDDpIgD49bxOhuZ6U3cuP+tssNnz3PdvI=; b=LLcBPUGauKqKSfuOzq5UqdeNqJOLlFk4SgfyTGPhWhXf+Zj91lWpITHOlFKTbdtwWf BNRcNbWpUEm13m/NB4zGDHCpQ3vqXTXx+YEbuJkt2MjpuiuExN/4Kyq8hcCKF634BZYa M9Xf3nKAlhVPX6NYv86FmcYvNE3WEJFbXlrNU8DviPmnSg1o3VbaumvO+NF1KdH+qegi zOHXMmt1rQOllmznn27kVZ1Jk4yI1S8PzKRHP7i00LIQT1ckWfHwookxKVMGdTuHZaFd yqXbegmR4YiH76Y5DAGCzszjx4K+JL2qgqmSYn3Y2BRCUKFDSG89s9KnyuSQS8HTbvr2 Dazw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P0ZfSMYTTnjDDpIgD49bxOhuZ6U3cuP+tssNnz3PdvI=; b=PEF/E1xdab63GrSTnyOU+d5gfmP5VylGNLTkxdOnM0TDR3NmRfUQFcIu3D5Sjz4cin PAEVcH3q9GGvCCzfnyt+/3gk1OO6DsCQqehnFp5PZJ4ex4id5BHmAzwpHXfyyLW221Iy aekvVYJDrn0DUg127RtC7TvZuPjmHTKENEnpJCQtBoODOIe5Vhkf6xyJAy4Y4+tGzFJL Zp3TOV8jbpU+ph9UszK2QRY4K3SgOYXMxsfEFPlEH0N8igMsWnyFziN5V4eO1dF442Jv S43b9R/tlYdY1gWMAoy1eDbg6eXgp8D0j+BQS65gOz+eX9UauXxvre7F5InI2LFtcIPG RYaA== X-Gm-Message-State: AHQUAua8BnanHUNZtquGYufZjzw1fpFRGhqXTfOSl4p1Jre369GSK2ul x/7iH1SBa6cr5GEYS0379P3btna9WD4= X-Google-Smtp-Source: AHgI3IYq8+i+PrMFA6NroUWwVpz+ohT2LS2xPInO7XmSgh95d8lcp04FDUKWiaKYzaOc/s1L33poIA== X-Received: by 2002:adf:f181:: with SMTP id h1mr5141121wro.95.1549446148053; Wed, 06 Feb 2019 01:42:28 -0800 (PST) Received: from [192.168.1.2] ([194.53.187.240]) by smtp.gmail.com with ESMTPSA id n11sm16021765wrw.60.2019.02.06.01.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 01:42:27 -0800 (PST) Subject: Re: [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand To: Prashant Bhole , Alexei Starovoitov , Daniel Borkmann Cc: netdev@vger.kernel.org References: <20190206014556.3548-1-bhole_prashant_q7@lab.ntt.co.jp> From: Quentin Monnet Message-ID: Date: Wed, 6 Feb 2019 09:42:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190206014556.3548-1-bhole_prashant_q7@lab.ntt.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-02-06 10:45 UTC+0900 ~ Prashant Bhole > This patch adds missing information about feature-subcommand in > bpftool.rst > > Signed-off-by: Prashant Bhole My bad, thanks a lot for the update! > --- > tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/bpf/bpftool/Documentation/bpftool.rst b/tools/bpf/bpftool/Documentation/bpftool.rst > index 27153bb816ac..0685d5ada3ce 100644 > --- a/tools/bpf/bpftool/Documentation/bpftool.rst > +++ b/tools/bpf/bpftool/Documentation/bpftool.rst > @@ -16,7 +16,7 @@ SYNOPSIS > > **bpftool** **version** > > - *OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** } > + *OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** | **feature** } > > *OPTIONS* := { { **-V** | **--version** } | { **-h** | **--help** } > | { **-j** | **--json** } [{ **-p** | **--pretty** }] } > @@ -34,6 +34,8 @@ SYNOPSIS > > *NET-COMMANDS* := { **show** | **list** | **help** } > > + *FEATURE-COMMANDS* := { **probe** | **help** } Could you please fix this line to use a tab instead of spaces for indent, as for the rest of the file? > + > DESCRIPTION > =========== > *bpftool* allows for inspection and simple modification of BPF objects >