From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C7DC169C4 for ; Wed, 6 Feb 2019 19:09:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A6EA20844 for ; Wed, 6 Feb 2019 19:09:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CIGP7soP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbfBFTJD (ORCPT ); Wed, 6 Feb 2019 14:09:03 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44982 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfBFTJD (ORCPT ); Wed, 6 Feb 2019 14:09:03 -0500 Received: by mail-pf1-f196.google.com with SMTP id u6so3505753pfh.11 for ; Wed, 06 Feb 2019 11:09:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j4sd3QeocZQ8khBll9sdTJU02cFpu1A8oDG7WmTHG2o=; b=CIGP7soPcQPF/xr8KAJq92axJAYtm2yUmmHuWinNH57cy0j15LR2WfMUMmofCWOkSK nOHiIAI0eEkCkPsnU+lYqsMvqReqHKbKtQVLHZnrfcqiyWDHMsosGqn+IcnHmE6tVG6q pvy1RjoGjw7QluG/hOXD8ieFVhGFy7BVYtoLX+ACxGzJi8lew2MmsiiqBl3fEMWYBAYg UxnBn+EZzdnmv5xcbh9TEqtIasAMS3UQnK3jqcsziJnJSM3jd9T0vXf5L/TJB/Vi+TVk hquE5KHyLo6eexXsBUQFxWbxEKBsTZTnOGL0pfjs6RoVC7MY0KpsXEcPAFN6dIzbXSO4 Dc9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j4sd3QeocZQ8khBll9sdTJU02cFpu1A8oDG7WmTHG2o=; b=chD649gL4P6rfcotRajPws17ZGd9k4LexXuWTn88pXX8baapICWOai4dtpLUaV7O3c LjjczRrGC4/i/yiTgvBrvNJsl/bBLZnWs1uM/dd4n+k09kzULDlzebBRIX7JWmy0gBF8 QwiBVlbY836Gq88eLQLSzK6QVdhNkbUBDnp5Zf/cK3i4CCwP9QzJnyEXFCLKrb8IjHhS VGq3PBaZ7cHX8XaG0aIrCxKAJs0Cv0gUNuvtQ60fYrEhOv3pQLCnkSjtqYKAYy+fcQDC FGa3Y7Iq75lYhDMJyPemxogFpQZUXPvxfCZs1co9kdvMRNQWet9ky56vSbEeTcG9aXGV bIEw== X-Gm-Message-State: AHQUAuZ+Pr1u4He3Ak4SyVqkQ7hya+nmv8FP4Bx0fjp7rGS82EyMEiW8 0rc1fvibzmkhYswJ+1Rls3o= X-Google-Smtp-Source: AHgI3IaHUh+vU+y341A5oNKyRUFvUhAHQKG3KC9bIoyHpv3e1wx8vtDwXmSJXmM+7EXShHRrCTtzHA== X-Received: by 2002:a65:6392:: with SMTP id h18mr11119642pgv.107.1549480142909; Wed, 06 Feb 2019 11:09:02 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id y14sm6883885pgc.17.2019.02.06.11.09.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 11:09:01 -0800 (PST) Subject: Re: [PATCH net 1/2] geneve: should not call rt6_lookup() when ipv6 was disabled To: Stefano Brivio , David Ahern Cc: Hangbin Liu , netdev@vger.kernel.org, David Miller References: <20190206125111.5286-1-liuhangbin@gmail.com> <20190206125111.5286-2-liuhangbin@gmail.com> <9b7585c2-bab6-1c6c-7bab-9542406acf1a@gmail.com> <20190206200417.2c1b1e78@redhat.com> From: Eric Dumazet Message-ID: Date: Wed, 6 Feb 2019 11:09:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190206200417.2c1b1e78@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/06/2019 11:04 AM, Stefano Brivio wrote: > I guess if (__in6_dev_get(dev)) is already good, no? This is called > under RTNL. > Exactly ;)