From: Edward Cree <ecree.xilinx@gmail.com>
To: edward.cree@amd.com, linux-net-drivers@amd.com,
davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
habetsm.xilinx@gmail.com, sudheer.mogilappagari@intel.com,
jdamato@fastly.com, andrew@lunn.ch, mw@semihalf.com,
linux@armlinux.org.uk, sgoutham@marvell.com, gakula@marvell.com,
sbhatta@marvell.com, hkelam@marvell.com, saeedm@nvidia.com,
leon@kernel.org
Subject: Re: [RFC PATCH v3 net-next 4/7] net: ethtool: let the core choose RSS context IDs
Date: Tue, 19 Sep 2023 15:36:30 +0100 [thread overview]
Message-ID: <f0ecc83c-13c7-9cb8-ee2c-8b8e1cba7db1@gmail.com> (raw)
In-Reply-To: <20230919111038.GA25721@xcbmartinh41x.xilinx.com>
On 19/09/2023 12:10, Martin Habets wrote:
> On Tue, Sep 12, 2023 at 03:21:39PM +0100, edward.cree@amd.com wrote:
>> + int (*create_rxfh_context)(struct net_device *,
>> + struct ethtool_rxfh_context *ctx,
>> + const u32 *indir, const u8 *key,
>> + const u8 hfunc, u32 rss_context);
>
> To return the rss_context this creates shouldn't it use a pointer to
> rss_context here?
No, the whole point of this new API is that the core, not the
driver, chooses the value of rss_context. Does the commit
message not explain that sufficiently?
(If you look at Patch #7 you'll see that sfc doesn't even use the
value, though other drivers might if their HW has a fixed set of
slots for RSS configs.)
-ed
next prev parent reply other threads:[~2023-09-19 14:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 14:21 [RFC PATCH v3 net-next 0/7] ethtool: track custom RSS contexts in the core edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 1/7] net: move ethtool-related netdev state into its own struct edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 2/7] net: ethtool: attach an IDR of custom RSS contexts to a netdevice edward.cree
2023-09-12 16:36 ` Russell King (Oracle)
2023-09-13 11:22 ` Edward Cree
2023-09-13 15:10 ` Matthew Wilcox
2023-09-12 14:21 ` [RFC PATCH v3 net-next 3/7] net: ethtool: record custom RSS contexts in the IDR edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 4/7] net: ethtool: let the core choose RSS context IDs edward.cree
2023-09-19 11:10 ` Martin Habets
2023-09-19 14:36 ` Edward Cree [this message]
2023-09-20 9:05 ` Martin Habets
2023-09-12 14:21 ` [RFC PATCH v3 net-next 5/7] net: ethtool: add an extack parameter to new rxfh_context APIs edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts edward.cree
2023-09-12 16:40 ` Russell King (Oracle)
2023-09-13 11:24 ` Edward Cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 7/7] sfc: use new rxfh_context API edward.cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ecc83c-13c7-9cb8-ee2c-8b8e1cba7db1@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=gakula@marvell.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hkelam@marvell.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).