From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12D43134CFA for ; Thu, 22 Feb 2024 13:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708609815; cv=none; b=ZGbn9NoY//1RVT8wNGxfpb5EkZOiDuV5ZPUPmBaY359bnS2DWymz0lHeSGr7klmes6Ru94Gln/DDDZzZ5jzUSB8/t2snlYcy2M3zWavTiXxe23Qhr1adRm/tHNbixEjszWu4bZvU3JLJJtk7e9RMut5b/TZIWjqKkDhHckjKvuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708609815; c=relaxed/simple; bh=sxjrviJKUO4ego+bavj+MGIR978E5EVGQ1XQmUcD98o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g4/WK2q5FQI309rYdEDAwKXPKfMnQkPzRb8NtKcbt1yykGobxV5Pu5KYdOkAfHkVvHQbD6chTpdqmLf8mr+9x0cPgVBttmTTwrZxydTKDRx/CQ6YFPJ1ds0tbHg4BHqKBPNcvnQEQjNI6KryC9cMPovgck7tf1DhOkNJJqrh6ts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Crwxl1B0; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Crwxl1B0" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-512be6fda52so5048114e87.0 for ; Thu, 22 Feb 2024 05:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708609812; x=1709214612; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pJephV2azj0AUd3p7RK/qiB+wFc6v/rmXTqmszZdGYI=; b=Crwxl1B0FjzMUgXzRAjhwhKxjXDFfw3cobauF6YUniUd/URytp6IHP1Sw1shFQENJY JvKlW6TCh6riS9OCk79869+f/zv6LF4/dBdtLhdQnMx6c+sT6Hz2fi5n+CLuAo5k3ypd tkMlRz5VwsMn8ho+xMbIhOlg0TS5LnwI/it2l6l5kAJwpNwITibGgZwkTQqtDYWQj1sR v8lRBtdRKj6OV26AgIDO1TFdzb5PWjhYPv38wC4o3EsRV3uYEGUO3zGPwpXhkY476LHS LWWZUrtbjxnULkm39+/fgX5Lq/g7OjIPXoZGjOIMV8G8b1UYnv1fDiGhyxYC6yvMGJY7 X28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708609812; x=1709214612; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pJephV2azj0AUd3p7RK/qiB+wFc6v/rmXTqmszZdGYI=; b=ou6Uu0bV6jyHaraiWJngIXzkjMCWuYkYSPvFFcw4XLEecBaO/Ju0HrHCuZGhCh2in8 bC/ysoLggDDgDjki8lnHNHkbTSbmp3x81uCgDEO8z5/3nMGjRwG1dbCPq2DhISQBqgvn UwVteYsJVdK6SX9NnEaak3wpXdNOpiI40HeO1r6he46M8Kgva4gG/4A/K73YSuHJoJ3h DD+j2dO6MWDLj475qPC6SfpHue1X7r0rxBVCf43mb0nxi+cflOZZlbplRRIvT7oYY9FZ 8cmiRrCBTlP1kEBMRTItHGAazjudK6XVWHlO0d9ICU2O0HlK4+8gvYG/+NjqY75093XJ WA0g== X-Forwarded-Encrypted: i=1; AJvYcCVdn5mhJbGiwBLIIZ0oXjiYJH9qcVGLHEU6z5JrnQzfGmdXq+S10hluMzwO/1YBWnoEqa34xFXM4OJI09ELhbUuGTMPTRJv X-Gm-Message-State: AOJu0YwtUYL2uOlrkFVFuheus3dNysxCoHIfyZXHpL+r/TjXqVL6OKUQ ieuybdFWr2jaOnV+olh5o6JAPAgkJ211nfLNX6eo9LwwJXvunCFfLMIayuiUY1Q= X-Google-Smtp-Source: AGHT+IE9BXN2VEhMe3Dj96ylym+FP0b5Vptp4csqYAGSEtnaJOuMGHCx4Xtg1mVnTPnIJMauzl6yEA== X-Received: by 2002:a05:6512:4cd:b0:512:c802:7a9 with SMTP id w13-20020a05651204cd00b00512c80207a9mr5048333lfq.38.1708609812269; Thu, 22 Feb 2024 05:50:12 -0800 (PST) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id r11-20020a05600c35cb00b004120537210esm6505491wmq.46.2024.02.22.05.50.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 05:50:11 -0800 (PST) Message-ID: Date: Thu, 22 Feb 2024 14:50:11 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/9] thermal: Get rid of CONFIG_THERMAL_WRITABLE_TRIPS Content-Language: en-US To: "Rafael J. Wysocki" , Linux PM Cc: Lukasz Luba , LKML , Stanislaw Gruszka , Srinivas Pandruvada , Zhang Rui , netdev@vger.kernel.org, Ido Schimmel , Petr Machata , Miri Korenblit , linux-wireless@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Manaf Meethalavalappu Pallikunhi References: <6017196.lOV4Wx5bFT@kreacher> <4545870.LvFx2qVVIh@kreacher> From: Daniel Lezcano In-Reply-To: <4545870.LvFx2qVVIh@kreacher> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/02/2024 19:26, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The only difference made by CONFIG_THERMAL_WRITABLE_TRIPS is whether or > not the writable trips mask passed during thermal zone registration > will take any effect, but whoever passes a non-zero writable trips mask > to thermal_zone_device_register_with_trips() can be forgiven thinking > that it will always work. > > Moreover, some thermal drivers expect user space to set trip temperature > values, so they select CONFIG_THERMAL_WRITABLE_TRIPS, possibly overriding > a manual choice to unset it and going against the design purportedly > allowing system integrators to decide on the writability of trip points > for the given kernel build. It is also set in one platform's defconfig. > > Forthermore, CONFIG_THERMAL_WRITABLE_TRIPS only affects trip temperature, > because trip hysteresis is writable as long as the thermal zone provides > a callback to update it, regardless of the CONFIG_THERMAL_WRITABLE_TRIPS > value. > > The above means that the symbol in question is used inconsistently and > its purpose is at least moot, so remove it and always take the writable > trip mask passed to thermal_zone_device_register_with_trips() into > account. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog