From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C6C8266B67; Tue, 8 Jul 2025 09:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751968259; cv=none; b=WUMEBGxmZwKWXlQwYLZcM/1ASfubVo3XwyER1ExBBZPTN5SLUKItJvBy2qDUyV2BHCCkaWQ3VvhXa37XyXZeGhkExfiTQoWHSm0XAHdtQPY9E3UVnhOHeEOOFS8pL9fUtmOw9eg4G1ExOEhRyNadiUmLKbt7LZDN4WuuUzsCIcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751968259; c=relaxed/simple; bh=2eu5s8VoKRnSj6Fq1XRT5mEFWqsss2QcY2xiIuHGw44=; h=Message-ID:Date:MIME-Version:CC:Subject:To:References:From: In-Reply-To:Content-Type; b=nxbHRJPNLnOTpuy+xh7hI/IfOercRZR5eFGNCF1O4DV2vcnSvU1AX37nyvZIY8EoeldMpWvbwvVyLfQTZAZZBZE+vO5DchsA7iKSQrr3QMTJSCadlTjIQ2FiZXT9amv/CLMLNT8YfWLVgYjEz9YyQtALqwMbx0mtvF4+Ti+u3Rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4bbwlt6LWlz2FbNW; Tue, 8 Jul 2025 17:28:58 +0800 (CST) Received: from kwepemk100013.china.huawei.com (unknown [7.202.194.61]) by mail.maildlp.com (Postfix) with ESMTPS id 680571A016C; Tue, 8 Jul 2025 17:30:52 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemk100013.china.huawei.com (7.202.194.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 8 Jul 2025 17:30:51 +0800 Message-ID: Date: Tue, 8 Jul 2025 17:30:51 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , , , , , , , Subject: Re: [PATCH net 1/4] net: hns3: fix concurrent setting vlan filter issue To: Simon Horman References: <20250702130901.2879031-1-shaojijie@huawei.com> <20250702130901.2879031-2-shaojijie@huawei.com> <20250704155216.GF41770@horms.kernel.org> From: Jijie Shao In-Reply-To: <20250704155216.GF41770@horms.kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemk100013.china.huawei.com (7.202.194.61) on 2025/7/4 23:52, Simon Horman wrote: > On Wed, Jul 02, 2025 at 09:08:58PM +0800, Jijie Shao wrote: >> From: Jian Shen >> >> The vport->req_vlan_fltr_en may be changed concurrently by function >> hclge_sync_vlan_fltr_state() called in periodic work task and >> function hclge_enable_vport_vlan_filter() called by user configuration. >> It may cause the user configuration inoperative. Fixes it by protect >> the vport->req_vlan_fltr by vport_lock. >> >> Fixes: fa6a262a2550 ("net: hns3: add support for VF modify VLAN filter state") > I think the commit sited above is for the VF driver, whereas this > patch addresses PF driver code. I think the following is the > correct tag: Yeah, I will fix it in v2. Thanks, Jijie Shao > > Fixes: 2ba306627f59 ("net: hns3: add support for modify VLAN filter state") > >> Signed-off-by: Jian Shen >> Signed-off-by: Jijie Shao > Otherwise, this looks good to me. > > Reviewed-by: Simon Horman > > >