From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH net-next v3 3/5] tc/act: remove unneeded RCU lock in action callback Date: Wed, 25 Jul 2018 07:59:48 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Cong Wang , Jiri Pirko , Daniel Borkmann , Marcelo Ricardo Leitner , Eyal Birger , "David S. Miller" To: Paolo Abeni , netdev@vger.kernel.org Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:46633 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728684AbeGYNLL (ORCPT ); Wed, 25 Jul 2018 09:11:11 -0400 Received: by mail-io0-f193.google.com with SMTP id i18-v6so6073027ioj.13 for ; Wed, 25 Jul 2018 04:59:49 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 24/07/18 04:06 PM, Paolo Abeni wrote: > Each lockless action currently does its own RCU locking in ->act(). > This is allows using plain RCU accessor, even if the context > is really RCU BH. > > This change drops the per action RCU lock, replace the accessors > with _bh variant, cleans up a bit the surronding code and documents > the RCU status in the relevant header. > No functional nor performance change is intended. > > The goal of this patch is clarifying that the RCU critical section > used by the tc actions extends up to the classifier's caller. > This and 2/5 seems to stand on their own merit. cheers, jamal