netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Fan Gong <gongfan1@huawei.com>, Zhu Yikai <zhuyikai1@h-partners.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Bjorn Helgaas <helgaas@kernel.org>, luosifu <luosifu@huawei.com>,
	Xin Guo <guoxin09@huawei.com>,
	Shen Chenyang <shenchenyang1@hisilicon.com>,
	Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
	Shi Jing <shijing34@huawei.com>,
	Meny Yossefi <meny.yossefi@huawei.com>,
	Gur Stavi <gur.stavi@huawei.com>, Lee Trager <lee@trager.us>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Suman Ghosh <sumang@marvell.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Joe Damato <jdamato@fastly.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH net-next v06 2/8] hinic3: Complete Event Queue interfaces
Date: Tue, 1 Jul 2025 14:42:16 +0200	[thread overview]
Message-ID: <f16bb726-e8ba-4b9f-9657-5860b4f118bf@redhat.com> (raw)
In-Reply-To: <4695dc0171c0366ef2fb4eb46e7a9738061164cb.1750937080.git.zhuyikai1@h-partners.com>

On 6/27/25 8:12 AM, Fan Gong wrote:
>  static void reschedule_eq_handler(struct hinic3_eq *eq)
>  {
> -	struct hinic3_aeqs *aeqs = aeq_to_aeqs(eq);
> +	if (eq->type == HINIC3_AEQ) {
> +		struct hinic3_aeqs *aeqs = aeq_to_aeqs(eq);
>  
> -	queue_work_on(WORK_CPU_UNBOUND, aeqs->workq, &eq->aeq_work);
> +		queue_work_on(WORK_CPU_UNBOUND, aeqs->workq, &eq->aeq_work);
> +	} else {
> +		tasklet_schedule(&eq->ceq_tasklet);

I'm sorry for the late feedback, but tasklets API are deprecated, the
suggested alternative is threaded IRQ.

/P


  reply	other threads:[~2025-07-01 12:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27  6:12 [PATCH net-next v06 0/8] net: hinic3: Add a driver for Huawei 3rd gen NIC - management interfaces Fan Gong
2025-06-27  6:12 ` [PATCH net-next v06 1/8] hinic3: Async Event Queue interfaces Fan Gong
2025-06-27  6:12 ` [PATCH net-next v06 2/8] hinic3: Complete " Fan Gong
2025-07-01 12:42   ` Paolo Abeni [this message]
2025-06-27  6:12 ` [PATCH net-next v06 3/8] hinic3: Command Queue framework Fan Gong
2025-06-27  6:12 ` [PATCH net-next v06 4/8] hinic3: Command Queue interfaces Fan Gong
2025-07-01 12:56   ` Paolo Abeni
2025-07-03  0:44     ` Fan Gong
2025-06-27  6:12 ` [PATCH net-next v06 5/8] hinic3: TX & RX Queue coalesce interfaces Fan Gong
2025-06-28 12:46   ` Vadim Fedorenko
2025-07-09  8:26     ` Gur Stavi
2025-07-09 11:56       ` Simon Horman
2025-07-09 13:20         ` Vadim Fedorenko
2025-06-27  6:12 ` [PATCH net-next v06 6/8] hinic3: Mailbox framework Fan Gong
2025-06-28 13:03   ` Vadim Fedorenko
2025-07-01  6:51     ` Fan Gong
2025-06-27  6:12 ` [PATCH net-next v06 7/8] hinic3: Mailbox management interfaces Fan Gong
2025-06-27  6:12 ` [PATCH net-next v06 8/8] hinic3: Interrupt request configuration Fan Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f16bb726-e8ba-4b9f-9657-5860b4f118bf@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gongfan1@huawei.com \
    --cc=guoxin09@huawei.com \
    --cc=gur.stavi@huawei.com \
    --cc=helgaas@kernel.org \
    --cc=horms@kernel.org \
    --cc=jdamato@fastly.com \
    --cc=kuba@kernel.org \
    --cc=lee@trager.us \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luosifu@huawei.com \
    --cc=meny.yossefi@huawei.com \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=shenchenyang1@hisilicon.com \
    --cc=shijing34@huawei.com \
    --cc=sumang@marvell.com \
    --cc=vadim.fedorenko@linux.dev \
    --cc=wulike1@huawei.com \
    --cc=zhoushuai28@huawei.com \
    --cc=zhuyikai1@h-partners.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).